-
Notifications
You must be signed in to change notification settings - Fork 696
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(freespace_planning_algorithms): add tests for updated astar algorithm #6623
Conversation
planning/freespace_planning_algorithms/test/src/test_freespace_planning_algorithms_astar.cpp
Outdated
Show resolved
Hide resolved
planning/freespace_planning_algorithms/test/src/test_freespace_planning_algorithms_astar.cpp
Outdated
Show resolved
Hide resolved
7699ff2
to
0ef18f7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The new tests look good. Please open the PR for review after simplifying the CMakeLists.txt
.
find_package(ament_cmake_ros REQUIRED) | ||
ament_add_ros_isolated_gtest(freespace_planning_algorithms_no_obstacles-test | ||
test/src/test_freespace_planning_algorithms_no_obstacles.cpp | ||
) | ||
target_link_libraries(freespace_planning_algorithms_no_obstacles-test | ||
freespace_planning_algorithms | ||
) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do not add two "test" in CMake (freespace_planning_algorithms-test
and freespace_planning_algorithms_no_obstacles-test
).
Instead, please have one freespace_planning_algorithms-test
with all test files.
You should also remove the find_package(ament_cmake_ros REQUIRED)
.
6bbc91c
to
628ae0e
Compare
@@ -0,0 +1,418 @@ | |||
// Copyright 2024 Tier IV, Inc. All rights reserved. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tier IV -> TIER IV
Please check other files as well.
fb9bc20
to
a68c6e5
Compare
This pull request has been automatically marked as stale because it has not had recent activity. |
@takayuki5168 @mkquda hello, @NorahXiong from AutoCore will take over this task, do you have anything to share on this PR? |
@xmfcx @takayuki5168
|
@mkquda thanks for letting us know, I will close this PR then ✅ |
Description
Refer PR for updated algorithm: #6526
New tests are added to evaluate the updated astar introduced in above PR. New test file created in
planning/freespace_planning_algorithms/test/src/test_freespace_planning_algorithms_astar.cpp
The test file runs the astar search for a number of start and goal poses, and can dump the rosbag. The rosbag can then be visualized using
src/universe/autoware.universe/planning/freespace_planning_algorithms/test/debug_plot.py
.Three test cases are compared, 1) old algorithm without any improvements (
9m
curvature), 2) new algorithm with5m
min radius and9m
max radius, with an extra7m
radius also being made during branch search. It is also usingcurve weight: true
+complete algorithm: true
flags. 3) same as case 2) but withcurve weight: false
turned off.Tests performed
The new tests were run, rosbag saved and the resulting plots from
debug_plot.py
are shown below.Effects on system behavior
Does not effect simulator.
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.