Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(freespace_planning_algorithms): add tests for updated astar algorithm #6623

Closed
wants to merge 5 commits into from

Conversation

4swinv
Copy link
Contributor

@4swinv 4swinv commented Mar 15, 2024

Description

Refer PR for updated algorithm: #6526
New tests are added to evaluate the updated astar introduced in above PR. New test file created in planning/freespace_planning_algorithms/test/src/test_freespace_planning_algorithms_astar.cpp
The test file runs the astar search for a number of start and goal poses, and can dump the rosbag. The rosbag can then be visualized using src/universe/autoware.universe/planning/freespace_planning_algorithms/test/debug_plot.py.

Three test cases are compared, 1) old algorithm without any improvements (9m curvature), 2) new algorithm with 5m min radius and 9m max radius, with an extra 7m radius also being made during branch search. It is also using curve weight: true + complete algorithm: true flags. 3) same as case 2) but with curve weight: false turned off.

Tests performed

The new tests were run, rosbag saved and the resulting plots from debug_plot.py are shown below.

image
image

Effects on system behavior

Does not effect simulator.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Mar 15, 2024
@4swinv 4swinv force-pushed the fpa-update-tests branch from 7699ff2 to 0ef18f7 Compare March 15, 2024 09:15
Copy link
Contributor

@maxime-clem maxime-clem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The new tests look good. Please open the PR for review after simplifying the CMakeLists.txt.

Comment on lines 37 to 42
find_package(ament_cmake_ros REQUIRED)
ament_add_ros_isolated_gtest(freespace_planning_algorithms_no_obstacles-test
test/src/test_freespace_planning_algorithms_no_obstacles.cpp
)
target_link_libraries(freespace_planning_algorithms_no_obstacles-test
freespace_planning_algorithms
)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do not add two "test" in CMake (freespace_planning_algorithms-test and freespace_planning_algorithms_no_obstacles-test).
Instead, please have one freespace_planning_algorithms-test with all test files.
You should also remove the find_package(ament_cmake_ros REQUIRED).

@4swinv 4swinv force-pushed the fpa-update-tests branch from 6bbc91c to 628ae0e Compare April 10, 2024 01:53
@4swinv 4swinv marked this pull request as ready for review April 10, 2024 02:02
@takayuki5168 takayuki5168 added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Apr 10, 2024
@@ -0,0 +1,418 @@
// Copyright 2024 Tier IV, Inc. All rights reserved.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tier IV -> TIER IV
Please check other files as well.

@4swinv 4swinv force-pushed the fpa-update-tests branch from fb9bc20 to a68c6e5 Compare April 10, 2024 07:43
Copy link

stale bot commented Jun 10, 2024

This pull request has been automatically marked as stale because it has not had recent activity.

@stale stale bot added the status:stale Inactive or outdated issues. (auto-assigned) label Jun 10, 2024
@xmfcx
Copy link
Contributor

xmfcx commented Dec 10, 2024

@takayuki5168 @mkquda hello,

@NorahXiong from AutoCore will take over this task, do you have anything to share on this PR?

@stale stale bot removed the status:stale Inactive or outdated issues. (auto-assigned) label Dec 10, 2024
@xmfcx
Copy link
Contributor

xmfcx commented Dec 11, 2024

@mkquda thanks for letting us know, I will close this PR then ✅

@xmfcx xmfcx closed this Dec 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants