-
Notifications
You must be signed in to change notification settings - Fork 696
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(behavior_path_planner, start_planner,goal_planner,lane_change,avoidance): implement a general behavior turn signal algorithm #6622
Closed
danielsanchezaran
wants to merge
13
commits into
autowarefoundation:main
from
tier4:feat/general_behavior_turn_signal_algorithm
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com>
Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com>
Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com>
Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com>
Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com>
Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com>
Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com>
Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com>
Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com>
Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com>
Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com>
Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com>
Separating this PR into several. |
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
component:planning
Route planning, decision-making, and navigation. (auto-assigned)
type:documentation
Creating or refining documentation. (auto-assigned)
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR aims at generalizing the method by which the behavior_path modules compute their output TurnSignalInfo. The implementation is based on the original calcTurnSignal implementation by the avoidance module, with some extra boolean inputs to accommodate how different modules work (Lane change, for example, shifts the target lane and not the ego's current lane). The method also detects when the ego vehicle is stuck (because a stop wall, a pedestrian) and cancels the turn signal if the ego vehicle is close to finishing its shifted path.
I believe the generalized behavior will prove useful when debugging problems with the blinkers and will facilitate the creation of new modules.
The methods have been tested in simulated scenarios and automated tests with seemingly no problems.
Examples:
Tests with the start planner, using shift pull out, geometric planners
start_planner_generalized_turn_signal.mp4
Tests for the LC and avoidance modules:
LC_and_avoidance_generalized_turn_signal.mp4
Full test for start planner ,goal planner & avoidance
cap-.2024-03-15-14-32-20.mp4
Backwards movement with geometric pullout:
cap-.2024-03-15-14-39-23.mp4
Related links
EVALUATOR TESTS -> No degradation: TIER IV INTERNAL LINK
Tests performed
PSIM
EVALUATOR TESTS -> No degradation: TIER IV INTERNAL LINK
Notes for reviewers
Interface changes
Effects on system behavior
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.