feat(crosswalk): ignore occlusions in the presence of traffic lights #6604
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maxime-clem
requested review from
kyoichi-sugahara,
soblin,
satoshi-ota,
shmpwk,
takayuki5168,
tkimura4 and
yuki-takagi-66
as code owners
Merged
4 tasks
github-actions
bot
added
type:documentation
dkoldaev
reviewed
Mar 28, 2024
planning/behavior_velocity_crosswalk_module/src/scene_crosswalk.cpp
Outdated
Show resolved
Hide resolved
dkoldaev
reviewed
Mar 28, 2024
maxime-clem
force-pushed
the
fix/crosswalk_occlusions-virtual-wall-text_ignore-with-traffic-lights
branch
from
17096f8 to
0bebece
Compare
dkoldaev
approved these changes
Mar 29, 2024
shmpwk
added
the
run:build-and-test-differential
Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>
Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>
takayuki5168
approved these changes
Mar 29, 2024
maxime-clem
force-pushed
the
fix/crosswalk_occlusions-virtual-wall-text_ignore-with-traffic-lights
branch
from
0bebece to
9ae7834
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6604 +/- ##
=======================================
Coverage 14.94% 14.95%
=======================================
Files 1937 1937
Lines 133617 133544 -73
Branches 39752 39753 +1
=======================================
Hits 19969 19969
+ Misses 91401 91327 -74
- Partials 22247 22248 +1
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. |
maxime-clem
deleted the
fix/crosswalk_occlusions-virtual-wall-text_ignore-with-traffic-lights
branch
karishma1911
pushed a commit
to Interplai/autoware.universe
that referenced
this pull request
Jun 3, 2024
…utowarefoundation#6604) Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Required launch PR: autowarefoundation/autoware_launch#919
Tests performed
Psim
Effects on system behavior
Not applicable.
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.