-
Notifications
You must be signed in to change notification settings - Fork 698
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(blind_spot): find collision point using sibling straight lanelet boundary #6599
fix(blind_spot): find collision point using sibling straight lanelet boundary #6599
Conversation
Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
ab3ddf3
to
9be0da2
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6599 +/- ##
=======================================
Coverage 14.80% 14.80%
=======================================
Files 1915 1915
Lines 132241 132227 -14
Branches 39318 39309 -9
=======================================
Hits 19574 19574
+ Misses 90835 90821 -14
Partials 21832 21832
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
4face85
to
f02b48f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…boundary (autowarefoundation#6599) Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
fix(blind_spot): find collision point using sibling straight lanelet boundary (autowarefoundation#6599)
…boundary (autowarefoundation#6599) Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp> Signed-off-by: kaigohirao <kaigo.hirao@proxima-ai-tech.com>
…boundary (autowarefoundation#6599) Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
Description
blind_spot module did not work in there are no conflicting lanes on the assigned lane. As a fallback, in that case, use the entry of the intersection lane for collision detection.
before this PR
If there is not conflicting lanelet, blind_spot module does not work properly or does nothing.
PR6599-2024-03-13_12.01.54.mp4
after this PR
blind_spot module works without conflicting lanelet
PR6599-2024-03-13_11.56.18.mp4
Related links
https://tier4.atlassian.net/browse/RT1-5514
https://evaluation.tier4.jp/evaluation/reports/637486ef-6bc2-545c-b6bc-abe0f2285cd8?project_id=prd_jt
Tests performed
for normal left turn without straight branch
for right turn
for opposite vehicle
for same lane vehicle
Notes for reviewers
Interface changes
none
Effects on system behavior
none
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.