Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(blind_spot): find collision point using sibling straight lanelet boundary #6599

Merged

Conversation

soblin
Copy link
Contributor

@soblin soblin commented Mar 12, 2024

Description

blind_spot module did not work in there are no conflicting lanes on the assigned lane. As a fallback, in that case, use the entry of the intersection lane for collision detection.

before this PR

If there is not conflicting lanelet, blind_spot module does not work properly or does nothing.

PR6599-2024-03-13_12.01.54.mp4

after this PR

blind_spot module works without conflicting lanelet

PR6599-2024-03-13_11.56.18.mp4

Related links

https://tier4.atlassian.net/browse/RT1-5514

https://evaluation.tier4.jp/evaluation/reports/637486ef-6bc2-545c-b6bc-abe0f2285cd8?project_id=prd_jt

Tests performed

for normal left turn without straight branch

image

for right turn

for opposite vehicle

image

for same lane vehicle

image

Notes for reviewers

Interface changes

none

Effects on system behavior

none

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Mar 12, 2024
Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
@soblin soblin force-pushed the fix/blind-spot/absence-conflicting-lane branch from ab3ddf3 to 9be0da2 Compare March 13, 2024 00:58
@soblin soblin marked this pull request as ready for review March 13, 2024 03:09
@soblin soblin requested review from shmpwk and tkimura4 as code owners March 13, 2024 03:09
@soblin soblin added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Mar 13, 2024
Copy link

codecov bot commented Mar 13, 2024

Codecov Report

Attention: Patch coverage is 0% with 24 lines in your changes are missing coverage. Please review.

Project coverage is 14.80%. Comparing base (efe4e16) to head (9be0da2).
Report is 13 commits behind head on main.

❗ Current head 9be0da2 differs from pull request most recent head f02b48f. Consider uploading reports for the commit f02b48f to get more accurate results

Files Patch % Lines
.../behavior_velocity_blind_spot_module/src/scene.cpp 0.00% 24 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6599   +/-   ##
=======================================
  Coverage   14.80%   14.80%           
=======================================
  Files        1915     1915           
  Lines      132241   132227   -14     
  Branches    39318    39309    -9     
=======================================
  Hits        19574    19574           
+ Misses      90835    90821   -14     
  Partials    21832    21832           
Flag Coverage Δ *Carryforward flag
differential 13.44% <0.00%> (?)
total 14.80% <ø> (+<0.01%) ⬆️ Carriedforward from efe4e16

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@soblin soblin changed the title fix(blind_spot): make it work without conflicting lane fix(blind_spot): find collision point using sibling straight lanelet boundary Mar 13, 2024
Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
@soblin soblin force-pushed the fix/blind-spot/absence-conflicting-lane branch from 4face85 to f02b48f Compare March 13, 2024 06:18
Copy link
Contributor

@shmpwk shmpwk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@soblin soblin enabled auto-merge (squash) March 13, 2024 06:57
@soblin soblin merged commit 35d2143 into autowarefoundation:main Mar 13, 2024
19 checks passed
@soblin soblin deleted the fix/blind-spot/absence-conflicting-lane branch March 13, 2024 07:39
soblin added a commit to tier4/autoware.universe that referenced this pull request Mar 19, 2024
…boundary (autowarefoundation#6599)

Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
shmpwk added a commit to tier4/autoware.universe that referenced this pull request Mar 19, 2024
fix(blind_spot): find collision point using sibling straight lanelet boundary (autowarefoundation#6599)
kaigohirao pushed a commit to kaigohirao/autoware.universe that referenced this pull request Mar 22, 2024
…boundary (autowarefoundation#6599)

Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
Signed-off-by: kaigohirao <kaigo.hirao@proxima-ai-tech.com>
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request Jun 3, 2024
…boundary (autowarefoundation#6599)

Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants