chore(cspell): merge spell-check-partial and spell-check-all
#6596
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Kotaro Yoshimoto <pythagora.yoshimoto@gmail.com>
Signed-off-by: Kotaro Yoshimoto <pythagora.yoshimoto@gmail.com>
Signed-off-by: Kotaro Yoshimoto <pythagora.yoshimoto@gmail.com>
Signed-off-by: Kotaro Yoshimoto <pythagora.yoshimoto@gmail.com>
Signed-off-by: Kotaro Yoshimoto <pythagora.yoshimoto@gmail.com>
github-actions
bot
added
component:perception
HansRobo
added
the
run:build-and-test-differential
Signed-off-by: Kotaro Yoshimoto <pythagora.yoshimoto@gmail.com>
Signed-off-by: Kotaro Yoshimoto <pythagora.yoshimoto@gmail.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6596 +/- ##
=======================================
Coverage 14.80% 14.80%
=======================================
Files 1915 1915
Lines 132301 132244 -57
Branches 39320 39316 -4
=======================================
- Hits 19581 19578 -3
+ Misses 90888 90832 -56
- Partials 21832 21834 +2
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
@HansRobo How about adding workflow dispatch to github actions? |
Signed-off-by: Kotaro Yoshimoto <pythagora.yoshimoto@gmail.com>
h-ohta
approved these changes
Mar 12, 2024
|
@manato Could you review the change for bytetrack? |
miursh
approved these changes
Mar 13, 2024
manato
approved these changes
Mar 13, 2024
kaigohirao
pushed a commit
to kaigohirao/autoware.universe
that referenced
this pull request
Mar 22, 2024
…owarefoundation#6596) * chore(ci): expand the scope of spell-check-partial Signed-off-by: Kotaro Yoshimoto <pythagora.yoshimoto@gmail.com> * chore(cspell): clean up .cspell-partial.json Signed-off-by: Kotaro Yoshimoto <pythagora.yoshimoto@gmail.com> * chore(cspell): ignore words from bytetrack Signed-off-by: Kotaro Yoshimoto <pythagora.yoshimoto@gmail.com> * chore(cspell): rename spell-check-partial to spell-check Signed-off-by: Kotaro Yoshimoto <pythagora.yoshimoto@gmail.com> * chore(cspell): delete spell-check-all Signed-off-by: Kotaro Yoshimoto <pythagora.yoshimoto@gmail.com> * chore(cspell): leave spell-check-partial name for CI required settings Signed-off-by: Kotaro Yoshimoto <pythagora.yoshimoto@gmail.com> * chore(cspell): restore job name in spell-check-partial.yaml Signed-off-by: Kotaro Yoshimoto <pythagora.yoshimoto@gmail.com> * chore(cspell): add workflow dispatch trigger to spell-check-partial Signed-off-by: Kotaro Yoshimoto <pythagora.yoshimoto@gmail.com> --------- Signed-off-by: Kotaro Yoshimoto <pythagora.yoshimoto@gmail.com> Signed-off-by: kaigohirao <kaigo.hirao@proxima-ai-tech.com>
karishma1911
pushed a commit
to Interplai/autoware.universe
that referenced
this pull request
Jun 3, 2024
…owarefoundation#6596) * chore(ci): expand the scope of spell-check-partial Signed-off-by: Kotaro Yoshimoto <pythagora.yoshimoto@gmail.com> * chore(cspell): clean up .cspell-partial.json Signed-off-by: Kotaro Yoshimoto <pythagora.yoshimoto@gmail.com> * chore(cspell): ignore words from bytetrack Signed-off-by: Kotaro Yoshimoto <pythagora.yoshimoto@gmail.com> * chore(cspell): rename spell-check-partial to spell-check Signed-off-by: Kotaro Yoshimoto <pythagora.yoshimoto@gmail.com> * chore(cspell): delete spell-check-all Signed-off-by: Kotaro Yoshimoto <pythagora.yoshimoto@gmail.com> * chore(cspell): leave spell-check-partial name for CI required settings Signed-off-by: Kotaro Yoshimoto <pythagora.yoshimoto@gmail.com> * chore(cspell): restore job name in spell-check-partial.yaml Signed-off-by: Kotaro Yoshimoto <pythagora.yoshimoto@gmail.com> * chore(cspell): add workflow dispatch trigger to spell-check-partial Signed-off-by: Kotaro Yoshimoto <pythagora.yoshimoto@gmail.com> --------- Signed-off-by: Kotaro Yoshimoto <pythagora.yoshimoto@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
There are two spell-check workflows now.
One is
spell-check-allto check whole code of autoware.universe to observe all cspell errors.The another is
spell-check-partialto prevent additional typos from being introduced.These two workflows were used differently, but now the differences are gone, so they are combined in this pull-request.
Note: This pull-request don't edit the workflow name,
spell-check-partial, because the name is reffered by GitHub settings.Tests performed
The
spell-check-partialworflow passed.Effects on system behavior
Not applicable.
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.