Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(component_state_monitor): change pose_estimator_pose rate #6563

Conversation

YamatoAndo
Copy link
Contributor

@YamatoAndo YamatoAndo commented Mar 7, 2024

Description

I lowered the threshold of pose_estimator_pose because it was triggering too frequently.

related PR autowarefoundation/autoware_launch#910

Tests performed

Not applicable.

Effects on system behavior

Not applicable.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: Yamato Ando <yamato.ando@tier4.jp>
@YamatoAndo
Copy link
Contributor Author

Copy link
Contributor

@isamu-takagi isamu-takagi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@YamatoAndo YamatoAndo added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Mar 7, 2024
Copy link

codecov bot commented Mar 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 14.80%. Comparing base (7081a61) to head (20082c8).
Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6563   +/-   ##
=======================================
  Coverage   14.80%   14.80%           
=======================================
  Files        1917     1917           
  Lines      132086   132042   -44     
  Branches    39262    39253    -9     
=======================================
  Hits        19553    19553           
+ Misses      90715    90671   -44     
  Partials    21818    21818           
Flag Coverage Δ *Carryforward flag
differential 0.00% <ø> (?)
total 14.80% <ø> (+<0.01%) ⬆️ Carriedforward from 7081a61

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@YamatoAndo YamatoAndo merged commit 71c5669 into autowarefoundation:main Mar 8, 2024
35 checks passed
HansRobo pushed a commit that referenced this pull request Mar 12, 2024
Signed-off-by: Yamato Ando <yamato.ando@tier4.jp>
Signed-off-by: Kotaro Yoshimoto <pythagora.yoshimoto@gmail.com>
kaigohirao pushed a commit to kaigohirao/autoware.universe that referenced this pull request Mar 22, 2024
…refoundation#6563)

Signed-off-by: Yamato Ando <yamato.ando@tier4.jp>
Signed-off-by: kaigohirao <kaigo.hirao@proxima-ai-tech.com>
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request Jun 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:system System design and integration. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants