Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(perception modules): remove maintainer... #6499

Conversation

kyoichi-sugahara
Copy link
Contributor

@kyoichi-sugahara kyoichi-sugahara commented Feb 27, 2024

Description

remove maintainer from perception modules because they are not maintaining the packages for now.
we will add them again in near future, of course.
@wep21
If you want to keep maintaining the packages plese tell me and we all are welcome 😍

Add @miursh as maintainer for the tensorrt_classifilier package for now.

Tests performed

Not applicable.

Effects on system behavior

Not applicable.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>
@github-actions github-actions bot added component:perception Advanced sensor data processing and environment understanding. (auto-assigned) component:common Common packages from the autoware-common repository. (auto-assigned) labels Feb 27, 2024
@kyoichi-sugahara kyoichi-sugahara added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Feb 27, 2024
Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>
Copy link
Contributor

@miursh miursh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

codecov bot commented Feb 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 14.64%. Comparing base (209b672) to head (9038199).
Report is 12 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff            @@
##             main    #6499    +/-   ##
========================================
  Coverage   14.64%   14.64%            
========================================
  Files        1899     1899            
  Lines      130283   131048   +765     
  Branches    38311    38837   +526     
========================================
+ Hits        19082    19198   +116     
- Misses      89785    90345   +560     
- Partials    21416    21505    +89     
Flag Coverage Δ *Carryforward flag
differential 8.84% <ø> (?)
total 14.64% <ø> (+<0.01%) ⬆️ Carriedforward from 209b672

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@dan-dnn dan-dnn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@miursh miursh merged commit 1ec38b7 into autowarefoundation:main Feb 29, 2024
22 of 23 checks passed
@kyoichi-sugahara kyoichi-sugahara deleted the chore/miss_nishimatu_mingyu_san branch February 29, 2024 07:13
HansRobo pushed a commit that referenced this pull request Mar 12, 2024
* change maintainer

Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>

* add uetake san as maintainer

Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>

---------

Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>
Signed-off-by: Kotaro Yoshimoto <pythagora.yoshimoto@gmail.com>
kaigohirao pushed a commit to kaigohirao/autoware.universe that referenced this pull request Mar 22, 2024
)

* change maintainer

Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>

* add uetake san as maintainer

Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>

---------

Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>
Signed-off-by: kaigohirao <kaigo.hirao@proxima-ai-tech.com>
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request Jun 3, 2024
)

* change maintainer

Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>

* add uetake san as maintainer

Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>

---------

Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:common Common packages from the autoware-common repository. (auto-assigned) component:perception Advanced sensor data processing and environment understanding. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants