-
Notifications
You must be signed in to change notification settings - Fork 698
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(perception modules): remove maintainer... #6499
chore(perception modules): remove maintainer... #6499
Conversation
Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>
Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6499 +/- ##
========================================
Coverage 14.64% 14.64%
========================================
Files 1899 1899
Lines 130283 131048 +765
Branches 38311 38837 +526
========================================
+ Hits 19082 19198 +116
- Misses 89785 90345 +560
- Partials 21416 21505 +89
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
* change maintainer Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp> * add uetake san as maintainer Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp> --------- Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp> Signed-off-by: Kotaro Yoshimoto <pythagora.yoshimoto@gmail.com>
) * change maintainer Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp> * add uetake san as maintainer Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp> --------- Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp> Signed-off-by: kaigohirao <kaigo.hirao@proxima-ai-tech.com>
Description
remove maintainer from perception modules because they are not maintaining the packages for now.
we will add them again in near future, of course.
@wep21
If you want to keep maintaining the packages plese tell me and we all are welcome 😍
Add @miursh as maintainer for the
tensorrt_classifilier
package for now.Tests performed
Not applicable.
Effects on system behavior
Not applicable.
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.