Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(traffic_light): depend on is_simulation for scenario simulator #6498

Merged
merged 3 commits into from
Feb 29, 2024

fix

b755637
Select commit
Loading
Failed to load commit list.
Merged

feat(traffic_light): depend on is_simulation for scenario simulator #6498

fix
b755637
Select commit
Loading
Failed to load commit list.
CodeScene Delta Analysis / CodeScene Cloud Delta Analysis (main) succeeded Feb 27, 2024 in 36s

CodeScene PR Check

✅ Code Health Quality Gates: OK

  • Declining Code Health: 1 findings(s) 🚩
  • Improving Code Health: 0 findings(s) ✅
  • Affected Hotspots: 0 files(s) 🔥

Recommended Review Level: Lightweight sanity check
View detailed results in CodeScene

Details

🚩 Declining Code Health (highest to lowest):

  • Large Method node.cpp: BehaviorVelocityPlannerNode::BehaviorVelocityPlannerNode

Annotations

Check warning on line 151 in planning/behavior_velocity_planner/src/node.cpp

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)

❌ Getting worse: Large Method 

BehaviorVelocityPlannerNode::BehaviorVelocityPlannerNode increases from 72 to 73 lines of code, threshold = 70. Large functions with many lines of code are generally harder to understand and lower the code health. Avoid adding more lines to this function.
View more details on CodeScene Delta Analysis