Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(pointcloud_preprocessor): publish excluded points in ring_outlier_filter for debug purpose #6483

Merged
merged 4 commits into from
Feb 28, 2024

change variable name to avoid spell miss checker error

2ae8c9f
Select commit
Loading
Failed to load commit list.
Merged

feat(pointcloud_preprocessor): publish excluded points in ring_outlier_filter for debug purpose #6483

change variable name to avoid spell miss checker error
2ae8c9f
Select commit
Loading
Failed to load commit list.
CodeScene Delta Analysis / CodeScene Cloud Delta Analysis (main) failed Feb 28, 2024 in 39s

CodeScene PR Check

❌ Code Health Quality Gates: FAILED

  • Declining Code Health: 1 findings(s) 🚩
  • Improving Code Health: 0 findings(s) ✅
  • Affected Hotspots: 0 files(s) 🔥

Recommended Review Level: Detailed -- Inspect the code that degrades in code health.
View detailed results in CodeScene

Details

🚩 Declining Code Health (highest to lowest):

  • Complex Method ring_outlier_filter_nodelet.cpp: RingOutlierFilterComponent::faster_filter

Annotations

Check warning on line 217 in sensing/pointcloud_preprocessor/src/outlier_filter/ring_outlier_filter_nodelet.cpp

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)

❌ Getting worse: Complex Method 

RingOutlierFilterComponent::faster_filter increases in cyclomatic complexity from 22 to 23, threshold = 9. This function has many conditional statements (e.g. if, for, while), leading to lower code health. Avoid adding more conditionals and code to it without refactoring.
View more details on CodeScene Delta Analysis