Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(planning_debug_tools): fix .pages to make the deploy successful #6465

Merged
merged 2 commits into from
Feb 28, 2024

Conversation

KYabuuchi
Copy link
Contributor

@KYabuuchi KYabuuchi commented Feb 21, 2024

Description

Fixes:

I fixed .pages to make the deploy-docs successful.

It seems that the .pages format was broken by #6444

Previously, deploy-docs had been failing.
image

Tests performed

  1. I have confirmed that docs are generated correctly in the local environment.
cd /autoware/src/universe/autoware.universe
mkdocs serve
  1. The github-actions successed to deploy.
    image

Effects on system behavior

This PR does not affect.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: Kento Yabuuchi <kento.yabuuchi.2@tier4.jp>
@KYabuuchi KYabuuchi added the run:deploy-docs Mark for deploy-docs action generation. (used-by-ci) label Feb 21, 2024
Copy link

Documentation URL: https://autowarefoundation.github.io/autoware.universe/pr-6465/
Modified URLs:

@KYabuuchi KYabuuchi marked this pull request as ready for review February 21, 2024 02:15
@KYabuuchi KYabuuchi added run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) component:planning Route planning, decision-making, and navigation. (auto-assigned) labels Feb 21, 2024
@xmfcx
Copy link
Contributor

xmfcx commented Feb 28, 2024

Screenshot from 2024-02-28 20-37-09

@KYabuuchi -san, well, we solved the same problem twice 🤷‍♂️

I searched the issues for the problem but forgot to search PRs too.

@xmfcx xmfcx self-assigned this Feb 28, 2024
@github-actions github-actions bot removed the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Feb 28, 2024
@xmfcx xmfcx self-requested a review February 28, 2024 17:43
Copy link
Contributor

@xmfcx xmfcx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@xmfcx xmfcx merged commit 4da69c9 into autowarefoundation:main Feb 28, 2024
20 checks passed
@KYabuuchi KYabuuchi deleted the docs/fix_planning_mkdocs branch March 6, 2024 08:17
HansRobo pushed a commit that referenced this pull request Mar 12, 2024
…6465)

Signed-off-by: Kento Yabuuchi <kento.yabuuchi.2@tier4.jp>
Signed-off-by: Kotaro Yoshimoto <pythagora.yoshimoto@gmail.com>
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request Jun 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) run:deploy-docs Mark for deploy-docs action generation. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants