Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(detection): add maintainer #6450

Merged

Conversation

kminoda
Copy link
Contributor

@kminoda kminoda commented Feb 19, 2024

Description

Add myself in lidar_centerpoint and image_projection_based_fusion

Tests performed

Not applicable

Effects on system behavior

Not applicable

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: kminoda <koji.minoda@tier4.jp>
@github-actions github-actions bot added the component:perception Advanced sensor data processing and environment understanding. (auto-assigned) label Feb 19, 2024
@kminoda kminoda added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Feb 19, 2024
Copy link

codecov bot commented Feb 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (14e016f) 15.24% compared to head (63902b7) 14.89%.
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6450      +/-   ##
==========================================
- Coverage   15.24%   14.89%   -0.35%     
==========================================
  Files        1816     1866      +50     
  Lines      125147   128038    +2891     
  Branches    38188    38068     -120     
==========================================
- Hits        19075    19071       -4     
- Misses      84684    87637    +2953     
+ Partials    21388    21330      -58     
Flag Coverage Δ *Carryforward flag
differential 0.00% <ø> (?)
total 15.00% <ø> (-0.24%) ⬇️ Carriedforward from 54d25a8

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@knzo25 knzo25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kminoda kminoda merged commit 19e7bc7 into autowarefoundation:main Feb 19, 2024
30 of 32 checks passed
@kminoda kminoda deleted the chore/detection/add_maintainer branch February 19, 2024 23:18
StepTurtle pushed a commit to StepTurtle/autoware.universe that referenced this pull request Feb 28, 2024
Signed-off-by: kminoda <koji.minoda@tier4.jp>
HansRobo pushed a commit that referenced this pull request Mar 12, 2024
Signed-off-by: kminoda <koji.minoda@tier4.jp>
Signed-off-by: Kotaro Yoshimoto <pythagora.yoshimoto@gmail.com>
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request Jun 3, 2024
Signed-off-by: kminoda <koji.minoda@tier4.jp>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:perception Advanced sensor data processing and environment understanding. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants