refactor(mission_planner): add comment functions/remove unused stuff/add comment #6447
CodeScene PR Check
✅ Code Health Quality Gates: OK
- Declining Code Health: 0 findings(s) 🚩
- Improving Code Health: 3 findings(s) ✅
- Affected Hotspots: 0 files(s) 🔥
Recommended Review Level: Lightweight sanity check
View detailed results in CodeScene
Details
✅ Improving Code Health:
- Excess Number of Function Arguments default_planner.cpp: DefaultPlanner::check_goal_footprint
- Bumpy Road Ahead default_planner.cpp: DefaultPlanner::check_goal_footprint
- Excess Number of Function Arguments utility_functions.cpp: set_color
Annotations
Check notice on line 300 in planning/mission_planner/src/lanelet2_plugins/default_planner.cpp
codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)
✅ No longer an issue: Bumpy Road Ahead
DefaultPlanner::check_goal_footprint is no longer above the threshold for logical blocks with deeply nested code. The Bumpy Road code smell is a function that contains multiple chunks of nested conditional logic. The deeper the nesting and the more bumps, the lower the code health.
Check notice on line 300 in planning/mission_planner/src/lanelet2_plugins/default_planner.cpp
codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)
ℹ New issue: Bumpy Road Ahead
DefaultPlanner::check_goal_footprint_inside_lanes has 2 blocks with nested conditional logic. Any nesting of 2 or deeper is considered. Threshold is one single, nested block per function. The Bumpy Road code smell is a function that contains multiple chunks of nested conditional logic. The deeper the nesting and the more bumps, the lower the code health.
Check notice on line 300 in planning/mission_planner/src/lanelet2_plugins/default_planner.cpp
codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)
✅ No longer an issue: Excess Number of Function Arguments
DefaultPlanner::check_goal_footprint is no longer above the threshold for number of arguments. This function has too many arguments, indicating a lack of encapsulation. Avoid adding more arguments.
Check notice on line 300 in planning/mission_planner/src/lanelet2_plugins/default_planner.cpp
codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)
ℹ New issue: Excess Number of Function Arguments
DefaultPlanner::check_goal_footprint_inside_lanes has 5 arguments, threshold = 4. This function has too many arguments, indicating a lack of encapsulation. Avoid adding more arguments.
Check notice on line 37 in planning/mission_planner/src/lanelet2_plugins/utility_functions.cpp
codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)
✅ No longer an issue: Excess Number of Function Arguments
set_color is no longer above the threshold for number of arguments