Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(tier4_control_launch): fix control validator name duplication #6446

Merged
merged 3 commits into from
Feb 19, 2024
Merged

chore(tier4_control_launch): fix control validator name duplication #6446

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3f842fc
chore(tier4_control_launch): control validator name
soblin Feb 19, 2024
cd98d2b
Revert "chore(tier4_control_launch): control validator name"
soblin Feb 19, 2024
9102c44
just rename glog component
soblin Feb 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion launch/tier4_control_launch/launch/control.launch.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -379,7 +379,14 @@
namespace="",
package="rclcpp_components",
executable=LaunchConfiguration("container_executable"),
composable_node_descriptions=[control_validator_component, glog_component],
composable_node_descriptions=[
control_validator_component,
ComposableNode(
package="glog_component",
plugin="GlogComponent",
name="glog_validator_component",
),
],

Check warning on line 389 in launch/tier4_control_launch/launch/control.launch.py

View check run for this annotation

CodeScene Delta Analysis / CodeScene Cloud Delta Analysis (main)

❌ Getting worse: Large Method 

launch_setup increases from 320 to 327 lines of code, threshold = 70. Large functions with many lines of code are generally harder to understand and lower the code health. Avoid adding more lines to this function.
),
]
)
Expand Down
Loading