Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(blockage_diag): output blockage angle range bug fix #6445

Merged
merged 3 commits into from
Feb 19, 2024

Revert "chore: refactor"

26a771c
Select commit
Loading
Failed to load commit list.
Merged

fix(blockage_diag): output blockage angle range bug fix #6445

Revert "chore: refactor"
26a771c
Select commit
Loading
Failed to load commit list.
CodeScene Delta Analysis / CodeScene Cloud Delta Analysis (main) failed Feb 19, 2024 in 40s

CodeScene PR Check

❌ Code Health Quality Gates: FAILED

  • Declining Code Health: 1 findings(s) 🚩
  • Improving Code Health: 0 findings(s) ✅
  • Affected Hotspots: 0 files(s) 🔥

Recommended Review Level: Detailed -- Inspect the code that degrades in code health.
View detailed results in CodeScene

Details

🚩 Declining Code Health (highest to lowest):

  • Complex Method blockage_diag_nodelet.cpp: BlockageDiagComponent::filter

Annotations

Check warning on line 273 in sensing/pointcloud_preprocessor/src/blockage_diag/blockage_diag_nodelet.cpp

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)

❌ Getting worse: Complex Method 

BlockageDiagComponent::filter already has high cyclomatic complexity, and now it increases in Lines of Code from 235 to 237. This function has many conditional statements (e.g. if, for, while), leading to lower code health. Avoid adding more conditionals and code to it without refactoring.
View more details on CodeScene Delta Analysis