-
Notifications
You must be signed in to change notification settings - Fork 691
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(pointcloud_preprocessor): add maintainer #6442
chore(pointcloud_preprocessor): add maintainer #6442
Conversation
Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>
I would like to learn feature of blockage diag and review the PR |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6442 +/- ##
==========================================
- Coverage 14.99% 14.96% -0.03%
==========================================
Files 1839 1844 +5
Lines 127213 127451 +238
Branches 38132 38132
==========================================
Hits 19071 19071
- Misses 86808 87046 +238
Partials 21334 21334
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's okay. However, please note that although the pointcloud preprocessor is very large, it can be merged if one of the maintainers approve. 👍
Thank you 😍 |
3f21683
into
autowarefoundation:main
add kyoichi sugahara as code owner Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>
add kyoichi sugahara as code owner Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp> Signed-off-by: Kotaro Yoshimoto <pythagora.yoshimoto@gmail.com>
add kyoichi sugahara as code owner Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>
Description
Add @kyoichi-sugahara as maintainer for pointcloud_preprocessor package
mainly for maintaince of blockage diag feature
Tests performed
Not applicable.
Effects on system behavior
Not applicable.
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.