Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(pointcloud_preprocessor): add maintainer #6442

Conversation

kyoichi-sugahara
Copy link
Contributor

Description

Add @kyoichi-sugahara as maintainer for pointcloud_preprocessor package
mainly for maintaince of blockage diag feature

Tests performed

Not applicable.

Effects on system behavior

Not applicable.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>
@github-actions github-actions bot added the component:sensing Data acquisition from sensors, drivers, preprocessing. (auto-assigned) label Feb 17, 2024
@kyoichi-sugahara
Copy link
Contributor Author

I would like to learn feature of blockage diag and review the PR
@yukkysaito @miursh
I'm planing to evaluate the performance during snowfall and propose to temporarily become a maintainer. However, if adding a maintainer is not desirable, I will close this PR.

@kyoichi-sugahara kyoichi-sugahara added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Feb 17, 2024
Copy link

codecov bot commented Feb 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (e595755) 14.99% compared to head (d5be664) 14.96%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6442      +/-   ##
==========================================
- Coverage   14.99%   14.96%   -0.03%     
==========================================
  Files        1839     1844       +5     
  Lines      127213   127451     +238     
  Branches    38132    38132              
==========================================
  Hits        19071    19071              
- Misses      86808    87046     +238     
  Partials    21334    21334              
Flag Coverage Δ *Carryforward flag
differential 5.24% <ø> (?)
total 14.99% <ø> (ø) Carriedforward from e595755

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kyoichi-sugahara kyoichi-sugahara marked this pull request as ready for review February 17, 2024 14:49
Copy link
Contributor

@yukkysaito yukkysaito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's okay. However, please note that although the pointcloud preprocessor is very large, it can be merged if one of the maintainers approve. 👍

@kyoichi-sugahara
Copy link
Contributor Author

Thank you 😍
I was just curious why so many features are in the one package though

@kyoichi-sugahara kyoichi-sugahara merged commit 3f21683 into autowarefoundation:main Feb 19, 2024
31 of 32 checks passed
@kyoichi-sugahara kyoichi-sugahara deleted the chore/add_maintainer_pointcloud_preprocessor branch February 19, 2024 01:00
StepTurtle pushed a commit to StepTurtle/autoware.universe that referenced this pull request Feb 28, 2024
add kyoichi sugahara as code owner

Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>
HansRobo pushed a commit that referenced this pull request Mar 12, 2024
add kyoichi sugahara as code owner

Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>
Signed-off-by: Kotaro Yoshimoto <pythagora.yoshimoto@gmail.com>
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request Jun 3, 2024
add kyoichi sugahara as code owner

Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:sensing Data acquisition from sensors, drivers, preprocessing. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants