Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(tier4_control_launch): run control_validator out of main control container #6435

Merged

Conversation

soblin
Copy link
Contributor

@soblin soblin commented Feb 16, 2024

Description

divide control_validator from control_container

Related links

https://tier4.atlassian.net/browse/RT1-4972
https://tier4.atlassian.net/browse/RT1-5341
https://tier4.atlassian.net/browse/RT1-5342

Tests performed

before this PR

/control/control_container
  1  /control/trajectory_follower/controller_node_exe
  2  /control/external_cmd_selector
  3  /control/external_cmd_converter
  4  /control/control_validator
  5  /control/trajectory_follower/lane_departure_checker_node
  6  /control/shift_decider
  7  /control/vehicle_cmd_gate
  8  /control/operation_mode_transition_manager
  9  /control/glog_component

after this PR

/control/control_validator_container
  1  /control/control_validator
  2  /control/glog_component
/control/control_container
  1  /control/trajectory_follower/controller_node_exe
  2  /control/external_cmd_selector
  3  /control/external_cmd_converter
  4  /control/trajectory_follower/lane_departure_checker_node
  5  /control/shift_decider
  6  /control/vehicle_cmd_gate
  7  /control/operation_mode_transition_manager
  8  /control/glog_component

Notes for reviewers

Interface changes

none

Effects on system behavior

control validator is independent of control container.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

@github-actions github-actions bot added the component:launch Launch files, scripts and initialization tools. (auto-assigned) label Feb 16, 2024
… container

Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
@soblin soblin force-pushed the feat/control-validator-container branch from 5783054 to 0092a21 Compare February 16, 2024 05:14
@soblin soblin marked this pull request as ready for review February 16, 2024 05:21
@soblin soblin added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Feb 16, 2024
@soblin soblin enabled auto-merge (squash) February 16, 2024 06:47
@soblin soblin merged commit 13b8bdc into autowarefoundation:main Feb 16, 2024
31 of 32 checks passed
@soblin soblin deleted the feat/control-validator-container branch February 16, 2024 06:56
StepTurtle pushed a commit to StepTurtle/autoware.universe that referenced this pull request Feb 28, 2024
… container (autowarefoundation#6435)

Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
HansRobo pushed a commit that referenced this pull request Mar 12, 2024
… container (#6435)

Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
Signed-off-by: Kotaro Yoshimoto <pythagora.yoshimoto@gmail.com>
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request Jun 3, 2024
… container (autowarefoundation#6435)

Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:launch Launch files, scripts and initialization tools. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants