Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(diagnostic_graph_aggregator): add dump tool #6427

Conversation

isamu-takagi
Copy link
Contributor

@isamu-takagi isamu-takagi commented Feb 15, 2024

Description

Add dump tool for diagnostic_graph_aggregator.

Tests performed

  1. Run this command
    ros2 launch diagnostic_graph_aggregator example.launch.xml
  2. Run this command in another terminal
    ros2 run diagnostic_graph_aggregator dump
  3. Check that you see output like below
    | ----- | ----- | -------------------------------- | ----- |
    | index | level | name                             | links |
    | ----- | ----- | -------------------------------- | ----- |
    | 0     | OK    | /sensing/radars/front            |       |
    | 1     | OK    | /sensing/lidars/front            |       |
    | 2     | ERROR | /sensing/lidars/top              |       |
    | 3     | OK    | /functions/obstacle_detection    | 1 0   |
    | 4     | ERROR | /functions/pose_estimation       | 2     |
    | 5     | OK    | /external/remote_command         |       |
    | 6     | OK    | /external/joystick_command       |       |
    | 7     | ERROR | /autoware/modes/pull_over        | 4 3   |
    | 8     | OK    | /autoware/modes/comfortable_stop | 3     |
    | 9     | OK    | /autoware/modes/emergency_stop   |       |
    | 10    | OK    | /autoware/modes/remote           | 5     |
    | 11    | OK    | /autoware/modes/local            | 6     |
    | 12    | ERROR | /autoware/modes/autonomous       | 4 3   |
    | 13    | OK    | /autoware/modes/stop             |       |
    

Effects on system behavior

Not applicable.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>
Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>
@isamu-takagi isamu-takagi self-assigned this Feb 15, 2024
@github-actions github-actions bot added the component:system System design and integration. (auto-assigned) label Feb 15, 2024
Copy link
Contributor

@mkuri mkuri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>
@isamu-takagi isamu-takagi enabled auto-merge (squash) February 20, 2024 12:02
@isamu-takagi isamu-takagi enabled auto-merge (squash) February 20, 2024 12:19
@isamu-takagi isamu-takagi added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Feb 21, 2024
Copy link

codecov bot commented Feb 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (c9e6dda) 14.99% compared to head (d69d46e) 15.00%.
Report is 47 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6427   +/-   ##
=======================================
  Coverage   14.99%   15.00%           
=======================================
  Files        1838     1838           
  Lines      127099   127074   -25     
  Branches    38075    38065   -10     
=======================================
  Hits        19062    19062           
+ Misses      86715    86690   -25     
  Partials    21322    21322           
Flag Coverage Δ *Carryforward flag
differential 39.71% <ø> (?)
total 15.00% <ø> (+<0.01%) ⬆️ Carriedforward from c9e6dda

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@isamu-takagi isamu-takagi merged commit 11bb421 into autowarefoundation:main Feb 21, 2024
32 checks passed
StepTurtle pushed a commit to StepTurtle/autoware.universe that referenced this pull request Feb 28, 2024
…6427)

Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>
HansRobo pushed a commit that referenced this pull request Mar 12, 2024
Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>
Signed-off-by: Kotaro Yoshimoto <pythagora.yoshimoto@gmail.com>
TomohitoAndo pushed a commit to tier4/autoware.universe that referenced this pull request Mar 13, 2024
…6427)

Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>
TomohitoAndo added a commit to tier4/autoware.universe that referenced this pull request Mar 13, 2024
…6427) (#1189)

Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>
Co-authored-by: Takagi, Isamu <43976882+isamu-takagi@users.noreply.github.com>
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request Jun 3, 2024
…6427)

Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:system System design and integration. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants