Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(perception): fix typo #6420

Merged
merged 1 commit into from
Feb 15, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion perception/bytetrack/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ the number of false negatives is expected to decrease by using it.
The paper just says that the 2d tracking algorithm is a simple Kalman filter.
Original codes use the `top-left-corner` and `aspect ratio` and `size` as the state vector.

This is sometimes unstable because the aspectratio can be changed by the occlusion.
This is sometimes unstable because the aspect ratio can be changed by the occlusion.
So, we use the `top-left` and `size` as the state vector.

Kalman filter settings can be controlled by the parameters in `config/bytetrack_node.param.yaml`.
Expand Down
2 changes: 1 addition & 1 deletion perception/bytetrack/lib/include/data_type.h
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ typedef Eigen::Matrix<float, 1, 128, Eigen::RowMajor> FEATURE;
typedef Eigen::Matrix<float, Eigen::Dynamic, 128, Eigen::RowMajor> FEATURESS;
// typedef std::vector<FEATURE> FEATURESS;

// Kalmanfilter
// Kalman Filter
// typedef Eigen::Matrix<float, 8, 8, Eigen::RowMajor> KAL_FILTER;
typedef Eigen::Matrix<float, 1, 8, Eigen::RowMajor> KAL_MEAN;
typedef Eigen::Matrix<float, 8, 8, Eigen::RowMajor> KAL_COVA;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@ def generate_test_description():
FindPackageShare(PACKAGE_NAME).find(PACKAGE_NAME)
+ "/launch/synchronized_occupancy_grid_map_fusion.launch.xml"
)
# use default launch arguments and parms
# use default launch arguments and params
launch_args = []
# action to include launch file
test_launch_file = launch.actions.IncludeLaunchDescription(
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -380,7 +380,7 @@ TrackerState DecorativeTrackerMergerNode::createNewTracker(
const MEASUREMENT_STATE input_index, rclcpp::Time current_time,
const autoware_auto_perception_msgs::msg::TrackedObject & input_object)
{
// check if object id is not included in innner_tracker_objects_
// check if object id is not included in inner_tracker_objects_
for (const auto & object : inner_tracker_objects_) {
if (object.const_uuid_ == input_object.object_id) {
// create new uuid
Expand Down
Loading