chore(image_projection_based_fusion): rename debug topics #6418
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp>
github-actions
bot
added
the
component:perception
miursh
added
the
run:build-and-test-differential
badai-nguyen
requested review from
ktro2828,
miursh,
tzhong518,
YoshiRi and
yukkysaito
as code owners
|
Almost looks good. Just one question. |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #6418 +/- ##
==========================================
- Coverage 14.99% 14.96% -0.03%
==========================================
Files 1838 1843 +5
Lines 127099 127337 +238
Branches 38075 38075
==========================================
Hits 19062 19062
- Misses 86715 86953 +238
Partials 21322 21322
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp>
github-actions
bot
added
the
component:launch
miursh
approved these changes
Feb 16, 2024
StepTurtle
pushed a commit
to StepTurtle/autoware.universe
that referenced
this pull request
Feb 28, 2024
…undation#6418) * chore(image_projection_based_fusion): rename debug topics Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp> * style(pre-commit): autofix * fix: roi_pointcloud_fusion namespace Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp> --------- Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
HansRobo
pushed a commit
that referenced
this pull request
Mar 12, 2024
* chore(image_projection_based_fusion): rename debug topics Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp> * style(pre-commit): autofix * fix: roi_pointcloud_fusion namespace Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp> --------- Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Signed-off-by: Kotaro Yoshimoto <pythagora.yoshimoto@gmail.com>
karishma1911
pushed a commit
to Interplai/autoware.universe
that referenced
this pull request
Jun 3, 2024
…undation#6418) * chore(image_projection_based_fusion): rename debug topics Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp> * style(pre-commit): autofix * fix: roi_pointcloud_fusion namespace Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp> --------- Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
fusion.cppinterface.Related Link
TIER IV INTERNAL LINK
Tests performed
Confirm by logging_simulator that debug topics namespace matching with node name
Before:
/perception/object_recognition/detection/clustering/camera_lidar_fusion/image_projection_based_fusion/debug/roi0/timestamp_interval_ms /perception/object_recognition/detection/clustering/image_projection_based_fusion/debug/roi0/timestamp_interval_ms /perception/object_recognition/detection/image_projection_based_fusion/debug/roi0/timestamp_interval_ms /perception/object_recognition/detection/pointpainting/image_projection_based_fusion/debug/roi0/timestamp_interval_msAfter:
autoware@npc2201009-ubuntu22:~/autoware$ ros2 topic list | grep roi0/timestamp_interval_offset_ms /perception/object_recognition/detection/clustering/camera_lidar_fusion/roi_cluster_fusion/debug/roi0/timestamp_interval_offset_ms /perception/object_recognition/detection/clustering/roi_pointcloud_fusion/debug/roi0/timestamp_interval_offset_ms /perception/object_recognition/detection/pointpainting/pointpainting/debug/roi0/timestamp_interval_offset_ms /perception/object_recognition/detection/roi_detected_object_fusion/debug/roi0/timestamp_interval_offset_msNot applicable.
Effects on system behavior
Not applicable.
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.