fix(gnss_poser): fix tf transform #6404
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yamato Ando <yamato.ando@tier4.jp>
github-actions
bot
added
the
component:sensing
|
@FranzAlbers I have created a pull request to fix #3640 |
|
@YamatoAndo - san, thank you for your work. I encountered the same issue and successfully addressed it with this PR. Could you please take a look, @kminoda - san? This PR might be urgent for the correct transformation calculation. |
YamatoAndo
requested review from
anhnv3991,
KYabuuchi,
Motsu-san,
RyuYamamoto,
SakodaShintaro and
TaikiYamada4
as code owners
kminoda
approved these changes
Feb 20, 2024
YamatoAndo
added
the
run:build-and-test-differential
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #6404 +/- ##
=======================================
Coverage 15.11% 15.12%
=======================================
Files 1821 1821
Lines 126171 126150 -21
Branches 38188 38188
=======================================
Hits 19077 19077
+ Misses 85704 85683 -21
Partials 21390 21390
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Closed
3 tasks
StepTurtle
pushed a commit
to StepTurtle/autoware.universe
that referenced
this pull request
Feb 28, 2024
Signed-off-by: Yamato Ando <yamato.ando@tier4.jp> Co-authored-by: kminoda <44218668+kminoda@users.noreply.github.com>
HansRobo
pushed a commit
that referenced
this pull request
Mar 12, 2024
Signed-off-by: Yamato Ando <yamato.ando@tier4.jp> Co-authored-by: kminoda <44218668+kminoda@users.noreply.github.com> Signed-off-by: Kotaro Yoshimoto <pythagora.yoshimoto@gmail.com>
0x126
pushed a commit
to tier4/autoware.universe
that referenced
this pull request
Apr 18, 2024
Signed-off-by: Yamato Ando <yamato.ando@tier4.jp> Co-authored-by: kminoda <44218668+kminoda@users.noreply.github.com>
4 tasks
karishma1911
pushed a commit
to Interplai/autoware.universe
that referenced
this pull request
Jun 3, 2024
Signed-off-by: Yamato Ando <yamato.ando@tier4.jp> Co-authored-by: kminoda <44218668+kminoda@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
fix tf transform.
Isuee link #3640
Tests performed
LSim works.
confirmed that the TF transformation is correct. #3640 (comment)
Effects on system behavior
Not applicable.
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.