Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(dynamic_avoidance): fix minor bugs and comment #6358

Merged
merged 3 commits into from
Feb 9, 2024

Conversation

yuki-takagi-66
Copy link
Contributor

Description

fix incorrect codes

Tests performed

psim test

Effects on system behavior

Not applicable.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

fix incorrect comments

Signed-off-by: Yuki Takagi <yuki.takagi@tier4.jp>
@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Feb 8, 2024
@yuki-takagi-66 yuki-takagi-66 added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Feb 8, 2024
@yuki-takagi-66 yuki-takagi-66 marked this pull request as ready for review February 8, 2024 08:58
Copy link

codecov bot commented Feb 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (58695bd) 14.86% compared to head (dcc124d) 14.86%.
Report is 13 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6358   +/-   ##
=======================================
  Coverage   14.86%   14.86%           
=======================================
  Files        1845     1845           
  Lines      126697   126696    -1     
  Branches    37883    37883           
=======================================
  Hits        18830    18830           
+ Misses      86702    86701    -1     
  Partials    21165    21165           
Flag Coverage Δ *Carryforward flag
differential 6.92% <ø> (?)
total 14.86% <ø> (+<0.01%) ⬆️ Carriedforward from 12e8d0a

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Yuki Takagi <yuki.takagi@tier4.jp>
Signed-off-by: Yuki Takagi <yuki.takagi@tier4.jp>
@yuki-takagi-66 yuki-takagi-66 merged commit 5b18c25 into autowarefoundation:main Feb 9, 2024
22 of 23 checks passed
@yuki-takagi-66 yuki-takagi-66 deleted the da/fix-and-refactor branch February 9, 2024 04:22
StepTurtle pushed a commit to StepTurtle/autoware.universe that referenced this pull request Feb 28, 2024
…n#6358)

fix behavior_path_planner state
fix incorrect comments

Signed-off-by: Yuki Takagi <yuki.takagi@tier4.jp>
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request Jun 3, 2024
…n#6358)

fix behavior_path_planner state
fix incorrect comments

Signed-off-by: Yuki Takagi <yuki.takagi@tier4.jp>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants