Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(gnss_poser): no conversion when projection type is local #6356

Conversation

isamu-takagi
Copy link
Contributor

@isamu-takagi isamu-takagi commented Feb 8, 2024

Description

Fix an issue where the node dies when the projection type is local.

Related links

https://github.com/orgs/autowarefoundation/discussions/4157

Tests performed

  1. Add map_projector_info.yaml to the your map directory.

    projector_type: local
    
  2. Run the following command:

    • Terminal 1: ros2 launch gnss_poser gnss_poser.launch.xml
    • Terminal 2: ros2 topic pub /fix sensor_msgs/msg/NavSatFix
    • Terminal 3: ros2 topic pub /map/map_projector_info tier4_map_msgs/msg/MapProjectorInfo "{projector_type: local}"
  3. Check that the node is not died on terminal 1

    • main branch
      [gnss_poser-1] [WARN] [1707406335.757544980] [gnss_poser]: map_projector_info has not been received yet. Check if the map_projection_loader is successfully launched.
      [gnss_poser-1] [WARN] [1707406336.757630107] [gnss_poser]: map_projector_info has not been received yet. Check if the map_projection_loader is successfully launched.
      [gnss_poser-1] terminate called after throwing an instance of 'std::invalid_argument'
      [gnss_poser-1]   what():  Invalid map projector type: local. Currently supported types: MGRS, LocalCartesianUTM, and TransverseMercator
      
    • PR branch
      [gnss_poser-1] [WARN] [1707406223.428762538] [gnss_poser]: map_projector_info has not been received yet. Check if the map_projection_loader is successfully launched.
      [gnss_poser-1] [WARN] [1707406224.429247652] [gnss_poser]: map_projector_info has not been received yet. Check if the map_projection_loader is successfully launched.
      [gnss_poser-1] [ERROR] [1707406226.429217000] [gnss_poser]: map_projector_info is local projector type. Unable to convert GNSS pose.
      [gnss_poser-1] [ERROR] [1707406231.429275335] [gnss_poser]: map_projector_info is local projector type. Unable to convert GNSS pose.
      

Interface changes

None

Effects on system behavior

None

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>
@github-actions github-actions bot added the component:sensing Data acquisition from sensors, drivers, preprocessing. (auto-assigned) label Feb 8, 2024
@isamu-takagi isamu-takagi self-assigned this Feb 8, 2024
@isamu-takagi isamu-takagi marked this pull request as ready for review February 8, 2024 15:41
Copy link
Contributor

@kminoda kminoda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the fix. LGTM

@isamu-takagi isamu-takagi added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Feb 9, 2024
@isamu-takagi isamu-takagi enabled auto-merge (squash) February 9, 2024 02:49
Copy link

codecov bot commented Feb 9, 2024

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (4409d20) 14.87% compared to head (f1fb31c) 14.87%.
Report is 5 commits behind head on main.

Files Patch % Lines
sensing/gnss_poser/src/gnss_poser_core.cpp 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6356      +/-   ##
==========================================
- Coverage   14.87%   14.87%   -0.01%     
==========================================
  Files        1841     1841              
  Lines      126588   126591       +3     
  Branches    37962    37962              
==========================================
  Hits        18828    18828              
- Misses      86539    86542       +3     
  Partials    21221    21221              
Flag Coverage Δ *Carryforward flag
differential 0.00% <0.00%> (?)
total 14.87% <ø> (ø) Carriedforward from 4409d20

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@isamu-takagi isamu-takagi merged commit c8628bf into autowarefoundation:main Feb 9, 2024
37 of 40 checks passed
@isamu-takagi isamu-takagi deleted the fix/gnss-poser-local-projection-type branch February 9, 2024 04:45
StepTurtle pushed a commit to StepTurtle/autoware.universe that referenced this pull request Feb 28, 2024
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request Jun 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:sensing Data acquisition from sensors, drivers, preprocessing. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants