-
Notifications
You must be signed in to change notification settings - Fork 696
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(avoidance): limit drivable lane only when the ego in on original lane #6349
fix(avoidance): limit drivable lane only when the ego in on original lane #6349
Conversation
09df296
to
bacfc98
Compare
…lane Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
bacfc98
to
0a66438
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #6349 +/- ##
=======================================
Coverage 14.99% 14.99%
=======================================
Files 1839 1839
Lines 127122 127159 +37
Branches 38083 38100 +17
=======================================
+ Hits 19060 19070 +10
- Misses 86739 86755 +16
- Partials 21323 21334 +11
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. |
…lane (autowarefoundation#6349) Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
fix(avoidance): limit drivable lane only when the ego in on original lane (autowarefoundation#6349)
…lane (autowarefoundation#6349) Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
…lane (autowarefoundation#6349) Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
…lane (autowarefoundation#6349) Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
…lane (autowarefoundation#6349) Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
…lane (autowarefoundation#6349) Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
…lane (autowarefoundation#6349) Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
Description
There two bug in logic to limit avoidance shift length by traffic light signal.
BUG1: don't limit drivable area properly even when it's red signal.
Before this PR.

After this PR.

BUG2: don't keep limited drivable area after approving avoidance maneuver.
Before this PR.
simplescreenrecorder-2024-02-15_10.11.31.mp4
After this PR.
simplescreenrecorder-2024-02-15_10.41.57.mp4
Tests performed
Effects on system behavior
Nothing.
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.