fix(avoidance): limit drivable lane only when the ego in on original lane

[satoshi-ota]

Description

There two bug in logic to limit avoidance shift length by traffic light signal.

BUG1: don't limit drivable area properly even when it's red signal.

Before this PR.

After this PR.

BUG2: don't keep limited drivable area after approving avoidance maneuver.

Before this PR.

simplescreenrecorder-2024-02-15_10.11.31.mp4

After this PR.

simplescreenrecorder-2024-02-15_10.41.57.mp4

Tests performed

• TEST WITH XX1
• PASS TIER IV INTERNAL SCENARIOS ALL PASS

Effects on system behavior

Nothing.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

• I've confirmed the contribution guidelines.
• The PR follows the pull request guidelines.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

• The PR follows the pull request guidelines.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

• There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

[shmpwk]

LGTM

[codecov]

Codecov Report

Attention: 34 lines in your changes are missing coverage. Please review.

Comparison is base (5015007) 14.99% compared to head (0a66438) 14.99%.
Report is 7 commits behind head on main.

Files	Patch %	Lines
...nning/behavior_path_avoidance_module/src/scene.cpp	37.93%	11 Missing and 7 partials ⚠️
...nning/behavior_path_avoidance_module/src/utils.cpp	26.31%	5 Missing and 9 partials ⚠️
...path_avoidance_by_lane_change_module/src/scene.cpp	0.00%	0 Missing and 2 partials ⚠️

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #6349   +/-   ##
=======================================
  Coverage   14.99%   14.99%           
=======================================
  Files        1839     1839           
  Lines      127122   127159   +37     
  Branches    38083    38100   +17     
=======================================
+ Hits        19060    19070   +10     
- Misses      86739    86755   +16     
- Partials    21323    21334   +11     

Flag	Coverage Δ		*Carryforward flag
differential	13.10% <32.00%> (?)
total	14.98% <ø> (-0.01%)	⬇️	Carriedforward from 5015007

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.