Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(object_type_panel): update rosparam name config #6347

Merged

chore(object_type_panel): update rosparam name config

a3b50d4
Select commit
Loading
Failed to load commit list.
Merged

chore(object_type_panel): update rosparam name config #6347

chore(object_type_panel): update rosparam name config
a3b50d4
Select commit
Loading
Failed to load commit list.
This check has been archived and is scheduled for deletion. Learn more about checks retention
CodeScene Delta Analysis / CodeScene Cloud Delta Analysis (main) failed Feb 7, 2024 in 44s

CodeScene PR Check

Code Health Quality Gates: FAILED

  • Declining Code Health: 2 findings(s) 🚩
  • Improving Code Health: 0 findings(s) ✅
  • Affected Hotspots: 0 files(s) 🔥

Recommended Review Level: Detailed -- Inspect the code that degrades in code health.
View detailed results in CodeScene

Details

🚩 Declining Code Health (highest to lowest):

  • Large Method target_object_type_panel.cpp: TargetObjectTypePanel::setParameters
  • Complex Method target_object_type_panel.cpp: TargetObjectTypePanel::updateMatrix

Annotations

Check warning on line 296 in common/tier4_target_object_type_rviz_plugin/src/target_object_type_panel.cpp

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)

❌ Getting worse: Complex Method

TargetObjectTypePanel::updateMatrix increases in cyclomatic complexity from 14 to 15, threshold = 9. This function has many conditional statements (e.g. if, for, while), leading to lower code health. Avoid adding more conditionals and code to it without refactoring.

Check warning on line 221 in common/tier4_target_object_type_rviz_plugin/src/target_object_type_panel.cpp

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)

❌ Getting worse: Large Method

TargetObjectTypePanel::setParameters increases from 98 to 155 lines of code, threshold = 70. Large functions with many lines of code are generally harder to understand and lower the code health. Avoid adding more lines to this function.