Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(object_type_panel): update rosparam name config #6347

Merged

Conversation

TakaHoribe
Copy link
Contributor

@TakaHoribe TakaHoribe commented Feb 7, 2024

Description

Update some ros parameter names for the target_object_type

Tests performed

Before
image

After
image

Effects on system behavior

None

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>
@github-actions github-actions bot added the component:common Common packages from the autoware-common repository. (auto-assigned) label Feb 7, 2024
@TakaHoribe TakaHoribe added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Feb 7, 2024
Copy link

codecov bot commented Feb 7, 2024

Codecov Report

Attention: 11 lines in your changes are missing coverage. Please review.

Comparison is base (e2bd68f) 14.86% compared to head (a3b50d4) 14.86%.
Report is 11 commits behind head on main.

Files Patch % Lines
..._type_rviz_plugin/src/target_object_type_panel.cpp 0.00% 11 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6347      +/-   ##
==========================================
- Coverage   14.86%   14.86%   -0.01%     
==========================================
  Files        1845     1845              
  Lines      126611   126621      +10     
  Branches    37871    37871              
==========================================
  Hits        18822    18822              
- Misses      86632    86642      +10     
  Partials    21157    21157              
Flag Coverage Δ *Carryforward flag
differential 0.00% <0.00%> (?)
total 14.86% <ø> (+<0.01%) ⬆️ Carriedforward from e2bd68f

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@TakaHoribe TakaHoribe merged commit b574523 into autowarefoundation:main Feb 7, 2024
36 of 40 checks passed
@TakaHoribe TakaHoribe deleted the update-obj-type-panel-config branch February 7, 2024 07:43
anhnv3991 pushed a commit to anhnv3991/autoware.universe that referenced this pull request Feb 13, 2024
…tion#6347)

Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>
StepTurtle pushed a commit to StepTurtle/autoware.universe that referenced this pull request Feb 28, 2024
…tion#6347)

Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request Jun 3, 2024
…tion#6347)

Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:common Common packages from the autoware-common repository. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants