-
Notifications
You must be signed in to change notification settings - Fork 696
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: added a missing link in a comment in the pointpainting launcher #6345
chore: added a missing link in a comment in the pointpainting launcher #6345
Conversation
…cher Signed-off-by: Kenzo Lobos-Tsunekawa <kenzo.lobos@tier4.jp>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!!
perception/image_projection_based_fusion/launch/pointpainting_fusion.launch.xml
Outdated
Show resolved
Hide resolved
perception/image_projection_based_fusion/launch/pointpainting_fusion.launch.xml
Outdated
Show resolved
Hide resolved
…fusion.launch.xml Co-authored-by: kminoda <44218668+kminoda@users.noreply.github.com>
…fusion.launch.xml Co-authored-by: kminoda <44218668+kminoda@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6345 +/- ##
==========================================
+ Coverage 15.13% 15.21% +0.07%
==========================================
Files 1819 1821 +2
Lines 126013 125362 -651
Branches 38180 38174 -6
==========================================
- Hits 19073 19072 -1
+ Misses 85552 84905 -647
+ Partials 21388 21385 -3
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Memo: Should be able to merge once this PR is merged: #6441 |
autowarefoundation#6345) * chore: added a missing PR link in a comment in the pointpainting launcher Signed-off-by: Kenzo Lobos-Tsunekawa <kenzo.lobos@tier4.jp> * Update perception/image_projection_based_fusion/launch/pointpainting_fusion.launch.xml Co-authored-by: kminoda <44218668+kminoda@users.noreply.github.com> * Update perception/image_projection_based_fusion/launch/pointpainting_fusion.launch.xml Co-authored-by: kminoda <44218668+kminoda@users.noreply.github.com> * style(pre-commit): autofix --------- Signed-off-by: Kenzo Lobos-Tsunekawa <kenzo.lobos@tier4.jp> Co-authored-by: kminoda <44218668+kminoda@users.noreply.github.com> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Shunsuke Miura <37187849+miursh@users.noreply.github.com>
#6345) * chore: added a missing PR link in a comment in the pointpainting launcher Signed-off-by: Kenzo Lobos-Tsunekawa <kenzo.lobos@tier4.jp> * Update perception/image_projection_based_fusion/launch/pointpainting_fusion.launch.xml Co-authored-by: kminoda <44218668+kminoda@users.noreply.github.com> * Update perception/image_projection_based_fusion/launch/pointpainting_fusion.launch.xml Co-authored-by: kminoda <44218668+kminoda@users.noreply.github.com> * style(pre-commit): autofix --------- Signed-off-by: Kenzo Lobos-Tsunekawa <kenzo.lobos@tier4.jp> Co-authored-by: kminoda <44218668+kminoda@users.noreply.github.com> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Shunsuke Miura <37187849+miursh@users.noreply.github.com> Signed-off-by: Kotaro Yoshimoto <pythagora.yoshimoto@gmail.com>
autowarefoundation#6345) * chore: added a missing PR link in a comment in the pointpainting launcher Signed-off-by: Kenzo Lobos-Tsunekawa <kenzo.lobos@tier4.jp> * Update perception/image_projection_based_fusion/launch/pointpainting_fusion.launch.xml Co-authored-by: kminoda <44218668+kminoda@users.noreply.github.com> * Update perception/image_projection_based_fusion/launch/pointpainting_fusion.launch.xml Co-authored-by: kminoda <44218668+kminoda@users.noreply.github.com> * style(pre-commit): autofix --------- Signed-off-by: Kenzo Lobos-Tsunekawa <kenzo.lobos@tier4.jp> Co-authored-by: kminoda <44218668+kminoda@users.noreply.github.com> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Shunsuke Miura <37187849+miursh@users.noreply.github.com>
Description
The explanation of a design choice was added in the centerpoint launcher.
The same explanation applies to pointpainting
autoware.universe/perception/lidar_centerpoint/launch/lidar_centerpoint.launch.xml
Line 23 in 02bc6d8
The reason for an explicit link is that due to linter changes among others, blame may not be efficient (this is common on other OSS projects)
Tests performed
Not applicable.
Effects on system behavior
Not applicable.
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.