Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: added a missing link in a comment in the pointpainting launcher #6345

Merged
merged 9 commits into from
Feb 20, 2024

Conversation

knzo25
Copy link
Contributor

@knzo25 knzo25 commented Feb 7, 2024

Description

The explanation of a design choice was added in the centerpoint launcher.
The same explanation applies to pointpainting

<!-- This parameter shall NOT be included in param file. See also: https://github.com/autowarefoundation/autoware.universe/pull/6167 -->

The reason for an explicit link is that due to linter changes among others, blame may not be efficient (this is common on other OSS projects)

Tests performed

Not applicable.

Effects on system behavior

Not applicable.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

…cher

Signed-off-by: Kenzo Lobos-Tsunekawa <kenzo.lobos@tier4.jp>
@knzo25 knzo25 requested a review from kminoda February 7, 2024 02:40
@github-actions github-actions bot added the component:perception Advanced sensor data processing and environment understanding. (auto-assigned) label Feb 7, 2024
kminoda
kminoda previously approved these changes Feb 7, 2024
Copy link
Contributor

@kminoda kminoda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!!

@kminoda kminoda dismissed their stale review February 7, 2024 02:41

Sorry I had one comment

knzo25 and others added 3 commits February 7, 2024 11:47
…fusion.launch.xml

Co-authored-by: kminoda <44218668+kminoda@users.noreply.github.com>
…fusion.launch.xml

Co-authored-by: kminoda <44218668+kminoda@users.noreply.github.com>
Copy link
Contributor

@kminoda kminoda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@knzo25 knzo25 added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Feb 19, 2024
@knzo25 knzo25 enabled auto-merge (squash) February 19, 2024 17:03
Copy link

codecov bot commented Feb 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (dd52489) 15.13% compared to head (86c192f) 15.21%.
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6345      +/-   ##
==========================================
+ Coverage   15.13%   15.21%   +0.07%     
==========================================
  Files        1819     1821       +2     
  Lines      126013   125362     -651     
  Branches    38180    38174       -6     
==========================================
- Hits        19073    19072       -1     
+ Misses      85552    84905     -647     
+ Partials    21388    21385       -3     
Flag Coverage Δ *Carryforward flag
differential 0.00% <ø> (?)
total 15.24% <ø> (+0.10%) ⬆️ Carriedforward from 81a84ca

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kminoda
Copy link
Contributor

kminoda commented Feb 19, 2024

Memo: Should be able to merge once this PR is merged: #6441

@knzo25 knzo25 disabled auto-merge February 20, 2024 04:40
@knzo25 knzo25 enabled auto-merge (squash) February 20, 2024 04:42
@knzo25 knzo25 merged commit 2036e2f into autowarefoundation:main Feb 20, 2024
22 of 23 checks passed
@knzo25 knzo25 deleted the chore/pointpainting_launcher branch February 20, 2024 12:30
StepTurtle pushed a commit to StepTurtle/autoware.universe that referenced this pull request Feb 28, 2024
autowarefoundation#6345)

* chore: added a missing PR link in a comment in the pointpainting launcher

Signed-off-by: Kenzo Lobos-Tsunekawa <kenzo.lobos@tier4.jp>

* Update perception/image_projection_based_fusion/launch/pointpainting_fusion.launch.xml

Co-authored-by: kminoda <44218668+kminoda@users.noreply.github.com>

* Update perception/image_projection_based_fusion/launch/pointpainting_fusion.launch.xml

Co-authored-by: kminoda <44218668+kminoda@users.noreply.github.com>

* style(pre-commit): autofix

---------

Signed-off-by: Kenzo Lobos-Tsunekawa <kenzo.lobos@tier4.jp>
Co-authored-by: kminoda <44218668+kminoda@users.noreply.github.com>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Shunsuke Miura <37187849+miursh@users.noreply.github.com>
HansRobo pushed a commit that referenced this pull request Mar 12, 2024
#6345)

* chore: added a missing PR link in a comment in the pointpainting launcher

Signed-off-by: Kenzo Lobos-Tsunekawa <kenzo.lobos@tier4.jp>

* Update perception/image_projection_based_fusion/launch/pointpainting_fusion.launch.xml

Co-authored-by: kminoda <44218668+kminoda@users.noreply.github.com>

* Update perception/image_projection_based_fusion/launch/pointpainting_fusion.launch.xml

Co-authored-by: kminoda <44218668+kminoda@users.noreply.github.com>

* style(pre-commit): autofix

---------

Signed-off-by: Kenzo Lobos-Tsunekawa <kenzo.lobos@tier4.jp>
Co-authored-by: kminoda <44218668+kminoda@users.noreply.github.com>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Shunsuke Miura <37187849+miursh@users.noreply.github.com>
Signed-off-by: Kotaro Yoshimoto <pythagora.yoshimoto@gmail.com>
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request Jun 3, 2024
autowarefoundation#6345)

* chore: added a missing PR link in a comment in the pointpainting launcher

Signed-off-by: Kenzo Lobos-Tsunekawa <kenzo.lobos@tier4.jp>

* Update perception/image_projection_based_fusion/launch/pointpainting_fusion.launch.xml

Co-authored-by: kminoda <44218668+kminoda@users.noreply.github.com>

* Update perception/image_projection_based_fusion/launch/pointpainting_fusion.launch.xml

Co-authored-by: kminoda <44218668+kminoda@users.noreply.github.com>

* style(pre-commit): autofix

---------

Signed-off-by: Kenzo Lobos-Tsunekawa <kenzo.lobos@tier4.jp>
Co-authored-by: kminoda <44218668+kminoda@users.noreply.github.com>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Shunsuke Miura <37187849+miursh@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:perception Advanced sensor data processing and environment understanding. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants