chore: added a missing link in a comment in the pointpainting launcher #6345
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…cher Signed-off-by: Kenzo Lobos-Tsunekawa <kenzo.lobos@tier4.jp>
knzo25
requested review from
badai-nguyen,
ktro2828,
miursh,
tzhong518,
YoshiRi and
yukkysaito
as code owners
github-actions
bot
added
the
component:perception
kminoda
reviewed
Feb 7, 2024
perception/image_projection_based_fusion/launch/pointpainting_fusion.launch.xml
Outdated
Show resolved
Hide resolved
perception/image_projection_based_fusion/launch/pointpainting_fusion.launch.xml
Outdated
Show resolved
Hide resolved
…fusion.launch.xml Co-authored-by: kminoda <44218668+kminoda@users.noreply.github.com>
…fusion.launch.xml Co-authored-by: kminoda <44218668+kminoda@users.noreply.github.com>
knzo25
added
the
run:build-and-test-differential
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6345 +/- ##
==========================================
+ Coverage 15.13% 15.21% +0.07%
==========================================
Files 1819 1821 +2
Lines 126013 125362 -651
Branches 38180 38174 -6
==========================================
- Hits 19073 19072 -1
+ Misses 85552 84905 -647
+ Partials 21388 21385 -3
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
Memo: Should be able to merge once this PR is merged: #6441 |
StepTurtle
pushed a commit
to StepTurtle/autoware.universe
that referenced
this pull request
Feb 28, 2024
autowarefoundation#6345) * chore: added a missing PR link in a comment in the pointpainting launcher Signed-off-by: Kenzo Lobos-Tsunekawa <kenzo.lobos@tier4.jp> * Update perception/image_projection_based_fusion/launch/pointpainting_fusion.launch.xml Co-authored-by: kminoda <44218668+kminoda@users.noreply.github.com> * Update perception/image_projection_based_fusion/launch/pointpainting_fusion.launch.xml Co-authored-by: kminoda <44218668+kminoda@users.noreply.github.com> * style(pre-commit): autofix --------- Signed-off-by: Kenzo Lobos-Tsunekawa <kenzo.lobos@tier4.jp> Co-authored-by: kminoda <44218668+kminoda@users.noreply.github.com> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Shunsuke Miura <37187849+miursh@users.noreply.github.com>
HansRobo
pushed a commit
that referenced
this pull request
Mar 12, 2024
#6345) * chore: added a missing PR link in a comment in the pointpainting launcher Signed-off-by: Kenzo Lobos-Tsunekawa <kenzo.lobos@tier4.jp> * Update perception/image_projection_based_fusion/launch/pointpainting_fusion.launch.xml Co-authored-by: kminoda <44218668+kminoda@users.noreply.github.com> * Update perception/image_projection_based_fusion/launch/pointpainting_fusion.launch.xml Co-authored-by: kminoda <44218668+kminoda@users.noreply.github.com> * style(pre-commit): autofix --------- Signed-off-by: Kenzo Lobos-Tsunekawa <kenzo.lobos@tier4.jp> Co-authored-by: kminoda <44218668+kminoda@users.noreply.github.com> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Shunsuke Miura <37187849+miursh@users.noreply.github.com> Signed-off-by: Kotaro Yoshimoto <pythagora.yoshimoto@gmail.com>
karishma1911
pushed a commit
to Interplai/autoware.universe
that referenced
this pull request
Jun 3, 2024
autowarefoundation#6345) * chore: added a missing PR link in a comment in the pointpainting launcher Signed-off-by: Kenzo Lobos-Tsunekawa <kenzo.lobos@tier4.jp> * Update perception/image_projection_based_fusion/launch/pointpainting_fusion.launch.xml Co-authored-by: kminoda <44218668+kminoda@users.noreply.github.com> * Update perception/image_projection_based_fusion/launch/pointpainting_fusion.launch.xml Co-authored-by: kminoda <44218668+kminoda@users.noreply.github.com> * style(pre-commit): autofix --------- Signed-off-by: Kenzo Lobos-Tsunekawa <kenzo.lobos@tier4.jp> Co-authored-by: kminoda <44218668+kminoda@users.noreply.github.com> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Shunsuke Miura <37187849+miursh@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The explanation of a design choice was added in the centerpoint launcher.
The same explanation applies to pointpainting
autoware.universe/perception/lidar_centerpoint/launch/lidar_centerpoint.launch.xml
Line 23 in 02bc6d8
The reason for an explicit link is that due to linter changes among others, blame may not be efficient (this is common on other OSS projects)
Tests performed
Not applicable.
Effects on system behavior
Not applicable.
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.