Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(probabilistic_occupancy_grid_map): move updater parameter to yaml file #6344

Closed
wants to merge 2 commits into from

feat: fix param loader

5ab3d14
Select commit
Loading
Failed to load commit list.
Closed

chore(probabilistic_occupancy_grid_map): move updater parameter to yaml file #6344

feat: fix param loader
5ab3d14
Select commit
Loading
Failed to load commit list.
This check has been archived and is scheduled for deletion. Learn more about checks retention
CodeScene Delta Analysis / CodeScene Cloud Delta Analysis (main) succeeded Feb 7, 2024 in 46s

CodeScene PR Check

✅ Code Health Quality Gates: OK

  • Declining Code Health: 1 findings(s) 🚩
  • Improving Code Health: 0 findings(s) ✅
  • Affected Hotspots: 0 files(s) 🔥

Recommended Review Level: Detailed -- Increased risk for defects: The risk is higher as much of the code in this repo (99% of all commits) is written by other authors.
View detailed results in CodeScene

Details

🚩 Declining Code Health (highest to lowest):

  • Large Method laserscan_based_occupancy_grid_map.launch.py: launch_setup

Annotations

Check warning on line 130 in perception/probabilistic_occupancy_grid_map/launch/laserscan_based_occupancy_grid_map.launch.py

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)

❌ Getting worse: Large Method 

launch_setup increases from 94 to 97 lines of code, threshold = 70. Large functions with many lines of code are generally harder to understand and lower the code health. Avoid adding more lines to this function.
View more details on CodeScene Delta Analysis