Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(probabilistic_occupancy_grid_map): move updater parameter to yaml file #6344

Closed
wants to merge 2 commits into from
Closed

chore(probabilistic_occupancy_grid_map): move updater parameter to yaml file #6344

wants to merge 2 commits into from

Conversation

YoshiRi
Copy link
Contributor

@YoshiRi YoshiRi commented Feb 7, 2024

Description

Related links

Tests performed

Notes for reviewers

Interface changes

Effects on system behavior

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

@YoshiRi
feat: try to move updater param description to yaml file
013c257 
Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com>
@YoshiRi
feat: fix param loader
5ab3d14 
Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com>
@github-actions github-actions bot added component:perception Advanced sensor data processing and environment understanding. (auto-assigned) component:launch Launch files, scripts and initialization tools. (auto-assigned) labels Feb 7, 2024
@YoshiRi
Copy link
Contributor Author

YoshiRi commented Feb 7, 2024

See https://docs.google.com/spreadsheets/d/1761KT4acv_5L34P2LcotOPcTFV_Y6UrL_JYOjoapOzs/edit#gid=0

@YoshiRi YoshiRi closed this Feb 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KeisukeShima KeisukeShima Awaiting requested review from KeisukeShima KeisukeShima will be requested when the pull request is marked ready for review KeisukeShima is a code owner

@taikitanaka3 taikitanaka3 Awaiting requested review from taikitanaka3 taikitanaka3 will be requested when the pull request is marked ready for review taikitanaka3 is a code owner

@TakaHoribe TakaHoribe Awaiting requested review from TakaHoribe TakaHoribe will be requested when the pull request is marked ready for review TakaHoribe is a code owner

@takayuki5168 takayuki5168 Awaiting requested review from takayuki5168 takayuki5168 will be requested when the pull request is marked ready for review takayuki5168 is a code owner

@tkimura4 tkimura4 Awaiting requested review from tkimura4 tkimura4 will be requested when the pull request is marked ready for review tkimura4 is a code owner

@technolojin technolojin Awaiting requested review from technolojin technolojin will be requested when the pull request is marked ready for review technolojin is a code owner

@yukkysaito yukkysaito Awaiting requested review from yukkysaito yukkysaito will be requested when the pull request is marked ready for review yukkysaito is a code owner

Assignees
No one assigned
Labels
component:launch Launch files, scripts and initialization tools. (auto-assigned) component:perception Advanced sensor data processing and environment understanding. (auto-assigned)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@YoshiRi