Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(tier4_adapi_rviz_plugin): add change button to the route panel #6326

Conversation

isamu-takagi
Copy link
Contributor

@isamu-takagi isamu-takagi commented Feb 6, 2024

Description

Add route change button to call /api/routing/change_route_points API.
Screenshot from 2024-02-06 10-08-28

Related links

None

Tests performed

  1. Launch planning simulation and initialize pose.
  2. Add RoutePanel by selecting "Panels" -> "Add new panel" from the rviz menu.
  3. Change the topic name of 2D Goal Pose to "/rviz/routing/pose" by the topic property panel.
  4. Clear the "auto clear" checkbox.
  5. Set the route.
  6. Set the route again
  7. Check that setting the route fails.
  8. Push change button
  9. Check that setting the route succeeds.

Notes for reviewers

None

Interface changes

None

Effects on system behavior

None

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

…anel

Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>
@github-actions github-actions bot added the component:common Common packages from the autoware-common repository. (auto-assigned) label Feb 6, 2024
@isamu-takagi isamu-takagi added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Feb 8, 2024
@isamu-takagi isamu-takagi enabled auto-merge (squash) February 8, 2024 10:22
@isamu-takagi isamu-takagi self-assigned this Feb 8, 2024
@isamu-takagi isamu-takagi merged commit 309deea into autowarefoundation:main Feb 9, 2024
35 of 36 checks passed
Copy link

codecov bot commented Feb 9, 2024

Codecov Report

Attention: 66 lines in your changes are missing coverage. Please review.

Comparison is base (0d10e81) 14.91% compared to head (7927e34) 14.90%.
Report is 61 commits behind head on main.

Files Patch % Lines
common/tier4_adapi_rviz_plugin/src/route_panel.cpp 0.00% 66 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6326      +/-   ##
==========================================
- Coverage   14.91%   14.90%   -0.01%     
==========================================
  Files        1817     1817              
  Lines      125357   125397      +40     
  Branches    37640    37629      -11     
==========================================
- Hits        18697    18693       -4     
- Misses      85651    85692      +41     
- Partials    21009    21012       +3     
Flag Coverage Δ *Carryforward flag
differential 0.00% <0.00%> (?)
total 14.91% <ø> (+<0.01%) ⬆️ Carriedforward from 9b4d7e4

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

StepTurtle pushed a commit to StepTurtle/autoware.universe that referenced this pull request Feb 28, 2024
…utowarefoundation#6326)

feat(tier4_adapi_rviz_plugin): add route change button to the route panel

Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request Jun 3, 2024
…utowarefoundation#6326)

feat(tier4_adapi_rviz_plugin): add route change button to the route panel

Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:common Common packages from the autoware-common repository. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants