Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(occlusion_spot): set proper condition on optional value #6301

Conversation

maxime-clem
Copy link
Contributor

Description

This PR fixes a bug introduced by #5832 when converting boost::optional to std::optional.
The condition if(pc == boost::none) was converted to if(pc) by mistake and this PR changes it to if(pc == std::nullopt).

Tests performed

Psim

Effects on system behavior

No more crash of the occlusion spot module

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>
@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Feb 5, 2024
Copy link
Contributor

@satoshi-ota satoshi-ota left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

image

@satoshi-ota satoshi-ota added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Feb 5, 2024
@maxime-clem maxime-clem enabled auto-merge (squash) February 5, 2024 03:01
Copy link

codecov bot commented Feb 5, 2024

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (0d10e81) 14.91% compared to head (ff26abf) 14.40%.
Report is 1 commits behind head on main.

❗ Current head ff26abf differs from pull request most recent head 078d407. Consider uploading reports for the commit 078d407 to get more accurate results

Files Patch % Lines
...occlusion_spot_module/src/occlusion_spot_utils.cpp 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6301      +/-   ##
==========================================
- Coverage   14.91%   14.40%   -0.52%     
==========================================
  Files        1817     1906      +89     
  Lines      125357   129852    +4495     
  Branches    37640    37575      -65     
==========================================
+ Hits        18697    18699       +2     
- Misses      85651    90159    +4508     
+ Partials    21009    20994      -15     
Flag Coverage Δ *Carryforward flag
differential 20.01% <0.00%> (?)
total 14.40% <ø> (-0.52%) ⬇️ Carriedforward from 7b1a414

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@maxime-clem maxime-clem merged commit 7e77488 into autowarefoundation:main Feb 5, 2024
16 of 17 checks passed
zulfaqar-azmi-t4 pushed a commit to zulfaqar-azmi-t4/autoware.universe that referenced this pull request Feb 6, 2024
shmpwk pushed a commit to tier4/autoware.universe that referenced this pull request Feb 8, 2024
anhnv3991 pushed a commit to anhnv3991/autoware.universe that referenced this pull request Feb 13, 2024
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request Jun 3, 2024
@maxime-clem maxime-clem deleted the fix/occlusion_spot-wrong_optional_condition branch June 28, 2024 05:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants