fix(occlusion_spot): set proper condition on optional value #6301
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>
maxime-clem
requested review from
shmpwk,
taikitanaka3 and
tkimura4
as code owners
github-actions
bot
added
the
component:planning
satoshi-ota
added
the
run:build-and-test-differential
shmpwk
approved these changes
Feb 5, 2024
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #6301 +/- ##
==========================================
- Coverage 14.91% 14.40% -0.52%
==========================================
Files 1817 1906 +89
Lines 125357 129852 +4495
Branches 37640 37575 -65
==========================================
+ Hits 18697 18699 +2
- Misses 85651 90159 +4508
+ Partials 21009 20994 -15
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. |
zulfaqar-azmi-t4
pushed a commit
to zulfaqar-azmi-t4/autoware.universe
that referenced
this pull request
Feb 6, 2024
…foundation#6301) Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>
shmpwk
pushed a commit
to tier4/autoware.universe
that referenced
this pull request
Feb 8, 2024
…foundation#6301) Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>
anhnv3991
pushed a commit
to anhnv3991/autoware.universe
that referenced
this pull request
Feb 13, 2024
…foundation#6301) Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>
karishma1911
pushed a commit
to Interplai/autoware.universe
that referenced
this pull request
Jun 3, 2024
…foundation#6301) Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes a bug introduced by #5832 when converting
boost::optionaltostd::optional.The condition
if(pc == boost::none)was converted toif(pc)by mistake and this PR changes it toif(pc == std::nullopt).Tests performed
Psim
Effects on system behavior
No more crash of the occlusion spot module
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.