-
Notifications
You must be signed in to change notification settings - Fork 696
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(occlusion_spot): set proper condition on optional value #6301
fix(occlusion_spot): set proper condition on optional value #6301
Conversation
Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #6301 +/- ##
==========================================
- Coverage 14.91% 14.40% -0.52%
==========================================
Files 1817 1906 +89
Lines 125357 129852 +4495
Branches 37640 37575 -65
==========================================
+ Hits 18697 18699 +2
- Misses 85651 90159 +4508
+ Partials 21009 20994 -15
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. |
…foundation#6301) Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>
…foundation#6301) Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>
…foundation#6301) Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>
…foundation#6301) Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>
Description
This PR fixes a bug introduced by #5832 when converting
boost::optional
tostd::optional
.The condition
if(pc == boost::none)
was converted toif(pc)
by mistake and this PR changes it toif(pc == std::nullopt)
.Tests performed
Psim
Effects on system behavior
No more crash of the occlusion spot module
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.