Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(intersection): initially ignore occlusion at intersection with tl, if tl info has never been available #6273

Merged
merged 1 commit into from
Feb 2, 2024

feat(intersection_occlusion): treat traffic light color as RED initially

ee83469
Select commit
Loading
Failed to load commit list.
Merged

feat(intersection): initially ignore occlusion at intersection with tl, if tl info has never been available #6273

feat(intersection_occlusion): treat traffic light color as RED initially
ee83469
Select commit
Loading
Failed to load commit list.
This check has been archived and is scheduled for deletion. Learn more about checks retention
CodeScene Delta Analysis / CodeScene Cloud Delta Analysis (main) failed Feb 2, 2024 in 46s

CodeScene PR Check

❌ Code Health Quality Gates: FAILED

  • Declining Code Health: 1 findings(s) 🚩
  • Improving Code Health: 0 findings(s) ✅
  • Affected Hotspots: 0 files(s) 🔥

Recommended Review Level: Detailed -- Inspect the code that degrades in code health.
View detailed results in CodeScene

Details

🚩 Declining Code Health (highest to lowest):

  • Complex Method scene_intersection_occlusion.cpp: IntersectionModule::getOcclusionStatus

Annotations

Check warning on line 63 in planning/behavior_velocity_intersection_module/src/scene_intersection_occlusion.cpp

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)

❌ Getting worse: Complex Method 

IntersectionModule::getOcclusionStatus increases in cyclomatic complexity from 11 to 12, threshold = 9. This function has many conditional statements (e.g. if, for, while), leading to lower code health. Avoid adding more conditionals and code to it without refactoring.
View more details on CodeScene Delta Analysis