Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(radar_tracks_noise_filter): refactor CMakeLists #6269

Conversation

scepter914
Copy link
Contributor

Description

Refactor CMakeLists of radar_tracks_noise_filter

Tests performed

Checked by compile

Effects on system behavior

No

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: scepter914 <scepter914@gmail.com>
@scepter914 scepter914 requested a review from miursh as a code owner February 1, 2024 03:22
@github-actions github-actions bot added the component:sensing Data acquisition from sensors, drivers, preprocessing. (auto-assigned) label Feb 1, 2024
@scepter914 scepter914 added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Feb 1, 2024
@HansRobo
Copy link
Member

HansRobo commented Feb 1, 2024

I updated this branch to import #6278.
This will help you pass build-and-test-differential faster.

Copy link

codecov bot commented Feb 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (742f44a) 14.38% compared to head (72bd594) 14.39%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff            @@
##             main    #6269    +/-   ##
========================================
  Coverage   14.38%   14.39%            
========================================
  Files        1907     1906     -1     
  Lines      129935   129798   -137     
  Branches    37616    37519    -97     
========================================
- Hits        18697    18686    -11     
+ Misses      90229    90151    -78     
+ Partials    21009    20961    -48     
Flag Coverage Δ *Carryforward flag
differential 41.26% <ø> (?)
total 14.39% <ø> (+<0.01%) ⬆️ Carriedforward from 0262c68

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@miursh miursh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@scepter914 scepter914 merged commit 1e45683 into autowarefoundation:main Feb 8, 2024
22 checks passed
@scepter914 scepter914 deleted the fix/refactor_radar_tracks_noise_filter branch February 8, 2024 15:24
StepTurtle pushed a commit to StepTurtle/autoware.universe that referenced this pull request Feb 28, 2024
…on#6269)

Signed-off-by: scepter914 <scepter914@gmail.com>
Co-authored-by: Kotaro Yoshimoto <pythagora.yoshimoto@gmail.com>
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request Jun 3, 2024
…on#6269)

Signed-off-by: scepter914 <scepter914@gmail.com>
Co-authored-by: Kotaro Yoshimoto <pythagora.yoshimoto@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:sensing Data acquisition from sensors, drivers, preprocessing. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants