Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(avoidance): fix bug in turn signal decision #6193

Merged

Conversation

satoshi-ota
Copy link
Contributor

@satoshi-ota satoshi-ota commented Jan 28, 2024

Description

Fix bug caused by #6188. Check opposite lane existence.

CURRENT TEST RESULT (80FAILs: 217/297)

Tests performed

Effects on system behavior

Nothing.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Jan 28, 2024
Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
@satoshi-ota satoshi-ota force-pushed the fix/turn-signal-avoidance branch from 19f2c7a to be8521d Compare January 28, 2024 06:04
@satoshi-ota satoshi-ota changed the title Fix/turn signal avoidance fix(avoidance): fix bug in turn signal decision Jan 28, 2024
@satoshi-ota satoshi-ota marked this pull request as ready for review January 28, 2024 10:48
@satoshi-ota satoshi-ota added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Jan 28, 2024
Copy link

codecov bot commented Jan 28, 2024

Codecov Report

Attention: 7 lines in your changes are missing coverage. Please review.

Comparison is base (1c4c3e3) 14.57% compared to head (be8521d) 14.57%.

Files Patch % Lines
...nning/behavior_path_avoidance_module/src/utils.cpp 0.00% 7 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6193      +/-   ##
==========================================
- Coverage   14.57%   14.57%   -0.01%     
==========================================
  Files        1874     1874              
  Lines      127671   127675       +4     
  Branches    37317    37321       +4     
==========================================
  Hits        18605    18605              
- Misses      88145    88149       +4     
  Partials    20921    20921              
Flag Coverage Δ *Carryforward flag
differential 13.20% <0.00%> (?)
total 14.57% <ø> (+<0.01%) ⬆️ Carriedforward from 1c4c3e3

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@shmpwk shmpwk merged commit 5218584 into autowarefoundation:main Jan 29, 2024
36 of 44 checks passed
shmpwk pushed a commit to tier4/autoware.universe that referenced this pull request Jan 29, 2024
)

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
@satoshi-ota satoshi-ota deleted the fix/turn-signal-avoidance branch January 29, 2024 01:46
anhnv3991 pushed a commit to anhnv3991/autoware.universe that referenced this pull request Jan 29, 2024
)

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
Signed-off-by: anhnv3991 <anh.nguyen.2@tier4.jp>
kyoichi-sugahara pushed a commit to kyoichi-sugahara/autoware.universe that referenced this pull request Jan 29, 2024
)

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
satoshi-ota added a commit to tier4/autoware.universe that referenced this pull request Feb 2, 2024
)

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
satoshi-ota added a commit to tier4/autoware.universe that referenced this pull request Feb 2, 2024
)

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
satoshi-ota added a commit to tier4/autoware.universe that referenced this pull request Feb 23, 2024
)

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
satoshi-ota added a commit to tier4/autoware.universe that referenced this pull request Mar 8, 2024
)

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
TomohitoAndo pushed a commit to tier4/autoware.universe that referenced this pull request Apr 1, 2024
)

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
satoshi-ota added a commit to tier4/autoware.universe that referenced this pull request Apr 8, 2024
)

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request Jun 3, 2024
)

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants