Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(pointpainting): fix param path declaration #6106

Merged
merged 3 commits into from
Jan 18, 2024

Conversation

kminoda
Copy link
Contributor

@kminoda kminoda commented Jan 18, 2024

Description

Fix declaration method of pointpainting. Aligning to that of centerpoint.

Tests performed

Launched pilot-auto.xx1 (TIER IV private repository) with pointpainting node and confirmed that it successfully launches and publishes the estimation.

Effects on system behavior

Not applicable

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: kminoda <koji.minoda@tier4.jp>
@github-actions github-actions bot added the component:launch Launch files, scripts and initialization tools. (auto-assigned) label Jan 18, 2024
@kminoda kminoda added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Jan 18, 2024
@kminoda kminoda marked this pull request as ready for review January 18, 2024 04:09
@shmpwk shmpwk requested a review from tzhong518 January 18, 2024 04:13
Copy link
Contributor

@YoshiRi YoshiRi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kminoda kminoda enabled auto-merge (squash) January 18, 2024 04:19
@kminoda kminoda disabled auto-merge January 18, 2024 04:24
Signed-off-by: kminoda <koji.minoda@tier4.jp>
Copy link
Contributor

@miursh miursh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: kminoda <koji.minoda@tier4.jp>
@kminoda kminoda enabled auto-merge (squash) January 18, 2024 05:03
@miursh miursh disabled auto-merge January 18, 2024 05:13
@miursh miursh merged commit dcc29f2 into main Jan 18, 2024
19 checks passed
@miursh miursh deleted the feat/pointpainting/fix_param_path branch January 18, 2024 05:28
shmpwk pushed a commit to tier4/autoware.universe that referenced this pull request Jan 18, 2024
* fix(pointpainting): fix param path declaration

Signed-off-by: kminoda <koji.minoda@tier4.jp>

* remove pointpainting_model_name

Signed-off-by: kminoda <koji.minoda@tier4.jp>

* revert: revert unnecessary change

Signed-off-by: kminoda <koji.minoda@tier4.jp>

---------

Signed-off-by: kminoda <koji.minoda@tier4.jp>
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request May 26, 2024
* fix(pointpainting): fix param path declaration

Signed-off-by: kminoda <koji.minoda@tier4.jp>

* remove pointpainting_model_name

Signed-off-by: kminoda <koji.minoda@tier4.jp>

* revert: revert unnecessary change

Signed-off-by: kminoda <koji.minoda@tier4.jp>

---------

Signed-off-by: kminoda <koji.minoda@tier4.jp>
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request May 28, 2024
* fix(pointpainting): fix param path declaration

Signed-off-by: kminoda <koji.minoda@tier4.jp>

* remove pointpainting_model_name

Signed-off-by: kminoda <koji.minoda@tier4.jp>

* revert: revert unnecessary change

Signed-off-by: kminoda <koji.minoda@tier4.jp>

---------

Signed-off-by: kminoda <koji.minoda@tier4.jp>
Signed-off-by: karishma <karishma@interpl.ai>
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request May 28, 2024
* fix(pointpainting): fix param path declaration

Signed-off-by: kminoda <koji.minoda@tier4.jp>

* remove pointpainting_model_name

Signed-off-by: kminoda <koji.minoda@tier4.jp>

* revert: revert unnecessary change

Signed-off-by: kminoda <koji.minoda@tier4.jp>

---------

Signed-off-by: kminoda <koji.minoda@tier4.jp>
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request Jun 3, 2024
* fix(pointpainting): fix param path declaration

Signed-off-by: kminoda <koji.minoda@tier4.jp>

* remove pointpainting_model_name

Signed-off-by: kminoda <koji.minoda@tier4.jp>

* revert: revert unnecessary change

Signed-off-by: kminoda <koji.minoda@tier4.jp>

---------

Signed-off-by: kminoda <koji.minoda@tier4.jp>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:launch Launch files, scripts and initialization tools. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants