Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(behavior_path_planner): add enable_all_modules_auto_mode argument to launch files for behavior path planner modules #6093

Conversation

kyoichi-sugahara
Copy link
Contributor

@kyoichi-sugahara kyoichi-sugahara commented Jan 16, 2024

Description

launcher change is in this PR
THIS PR SHOULD BE MERGED FIRST

auto_mode is controlled by parameter of enable_rtc

  • this is parameter for behavior_path_planner modules
  • this is one example fort behavior_belocity_planner modules

Independing on those parameter,
enable all module's auto_mode by adding enable_all_modules_auto_mode:=true when you launch autoware

Tests performed

with auto_mode for lane_change_left module is disabled

    lane_change_left:
      enable_rtc: false

confirmed auto_mode is disabled
image

with launch argument of enable_all_modules_auto_mode:=true
confirmed auto_mode is enabled
image

Effects on system behavior

Not applicable.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>
@github-actions github-actions bot added component:planning Route planning, decision-making, and navigation. (auto-assigned) component:launch Launch files, scripts and initialization tools. (auto-assigned) labels Jan 16, 2024
@kyoichi-sugahara kyoichi-sugahara changed the title feat(launcher): add enable_all_modules_auto_mode argument to launch files for behavior path planner modules feat(behavior_path_planner): add enable_all_modules_auto_mode argument to launch files for behavior path planner modules Jan 16, 2024
@kyoichi-sugahara kyoichi-sugahara marked this pull request as ready for review January 16, 2024 12:53
@satoshi-ota satoshi-ota self-assigned this Jan 17, 2024
@kyoichi-sugahara kyoichi-sugahara added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Jan 17, 2024
Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>
Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>
Copy link

codecov bot commented Jan 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (08b3a3d) 14.61% compared to head (24ad185) 14.61%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6093   +/-   ##
=======================================
  Coverage   14.61%   14.61%           
=======================================
  Files        1860     1860           
  Lines      127256   127256           
  Branches    37276    37276           
=======================================
  Hits        18598    18598           
  Misses      87741    87741           
  Partials    20917    20917           
Flag Coverage Δ *Carryforward flag
differential 11.70% <ø> (?)
total 14.61% <ø> (ø) Carriedforward from 08b3a3d

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kyoichi-sugahara kyoichi-sugahara merged commit 4379781 into autowarefoundation:main Jan 19, 2024
22 of 23 checks passed
@kyoichi-sugahara kyoichi-sugahara deleted the feat/add_enable_all_modules_auto_mode branch January 19, 2024 11:41
tkimura4 pushed a commit to tier4/autoware.universe that referenced this pull request Jan 23, 2024
…t to launch files for behavior path planner modules (autowarefoundation#6093)

* Add enable_all_modules_auto_mode argument to launch files

Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>

* set default value for enable_all_modules_auto_mode

Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>

* fix enable_rtc configuration in scene_module_manager_interface.hpp

Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>

---------

Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>
tkimura4 added a commit to tier4/autoware.universe that referenced this pull request Jan 23, 2024
* feat(behavior_path_planner): add enable_all_modules_auto_mode argument to launch files for behavior path planner modules (autowarefoundation#6093)

* Add enable_all_modules_auto_mode argument to launch files

Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>

* set default value for enable_all_modules_auto_mode

Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>

* fix enable_rtc configuration in scene_module_manager_interface.hpp

Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>

---------

Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>

* feat(behavior_velocity_planner): add enable_all_modules_auto_mode argument to launch files for behavior velocity planner modules (autowarefoundation#6094)

* set default value for enable_all_modules_auto_mode

Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>

* fix enable_rtc configuration in scene_module_manager_interface.hpp

Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>

* Refactor scene module managers to use getEnableRTC function

Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>

---------

Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>

---------

Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>
Co-authored-by: Kyoichi Sugahara <kyoichi.sugahara@tier4.jp>
saka1-s pushed a commit to saka1-s/autoware.universe that referenced this pull request Feb 15, 2024
…t to launch files for behavior path planner modules (autowarefoundation#6093)

* Add enable_all_modules_auto_mode argument to launch files

Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>

* set default value for enable_all_modules_auto_mode

Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>

* fix enable_rtc configuration in scene_module_manager_interface.hpp

Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>

---------

Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request Jun 3, 2024
…t to launch files for behavior path planner modules (autowarefoundation#6093)

* Add enable_all_modules_auto_mode argument to launch files

Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>

* set default value for enable_all_modules_auto_mode

Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>

* fix enable_rtc configuration in scene_module_manager_interface.hpp

Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>

---------

Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>
satoshi-ota pushed a commit to tier4/autoware.universe that referenced this pull request Jun 6, 2024
…t to launch files for behavior path planner modules (autowarefoundation#6093)

* Add enable_all_modules_auto_mode argument to launch files

Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>

* set default value for enable_all_modules_auto_mode

Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>

* fix enable_rtc configuration in scene_module_manager_interface.hpp

Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>

---------

Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:launch Launch files, scripts and initialization tools. (auto-assigned) component:planning Route planning, decision-making, and navigation. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants