-
Notifications
You must be signed in to change notification settings - Fork 696
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(perception/lidar_apollo_instance_segmentation): rework parameters #5739
refactor(perception/lidar_apollo_instance_segmentation): rework parameters #5739
Conversation
583022d
to
02eaecc
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I confirmed it works.
0989feb
to
50ee349
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5739 +/- ##
==========================================
+ Coverage 15.09% 15.31% +0.21%
==========================================
Files 1967 1765 -202
Lines 135941 119466 -16475
Branches 42122 35967 -6155
==========================================
- Hits 20520 18295 -2225
+ Misses 92700 80716 -11984
+ Partials 22721 20455 -2266
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. |
9785e57
to
b2f5cfb
Compare
perception/lidar_apollo_instance_segmentation/schema/lidar_apollo_instance_segmentation.json
Show resolved
Hide resolved
This pull request has been automatically marked as stale because it has not had recent activity. |
@yukkysaito @miursh please review and merge? |
@karishma1911 could you rebase this to the latest main? To fix the CI. Or click Allow edits and access to secrets by maintainers. For this PR. So we can do it for you. ![]() |
…ndation#5744) Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>
…5820) * refactor(side_shift): separate side shift module Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com> * refactor(bpp): remove side shift module Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com> --------- Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
…warefoundation#5689) fix(avoidance): output invalid avoidance path Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
Signed-off-by: GitHub <noreply@github.com> Co-authored-by: github-actions <github-actions@github.com>
…interpolate (autowarefoundation#5818) Fixed rejection criteria of SmartPoseBuffer::interpolate Signed-off-by: Shintaro Sakoda <shintaro.sakoda@tier4.jp>
…oid exceeding max voxel size (autowarefoundation#5824)
…utowarefoundation#5810) Add jerk and acc limits for slow-down Signed-off-by: Daniel Sanchez <daniel.sanchez@tier4.jp>
…arefoundation#5819) * fix(traffic_light): stop if the traffic light signal timed out Signed-off-by: Fumiya Watanabe <rej55.g@gmail.com> * fix(traffic_light): fix README format Signed-off-by: Fumiya Watanabe <rej55.g@gmail.com> --------- Signed-off-by: Fumiya Watanabe <rej55.g@gmail.com>
…c_time/elapsed_time, tentative objects (autowarefoundation#5762) * enable debugger in tracker Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com> * fix uninitialized class variable Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com> * feat: separate debugger class for simplification Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com> --------- Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com>
…utowarefoundation#5830) Signed-off-by: Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>
…refoundation#6087) Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
…affic light id map every callback (autowarefoundation#6061) Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
…compensation (autowarefoundation#6080) Signed-off-by: scepter914 <scepter914@gmail.com>
* fix(pointpainting): fix param path declaration Signed-off-by: kminoda <koji.minoda@tier4.jp> * remove pointpainting_model_name Signed-off-by: kminoda <koji.minoda@tier4.jp> * revert: revert unnecessary change Signed-off-by: kminoda <koji.minoda@tier4.jp> --------- Signed-off-by: kminoda <koji.minoda@tier4.jp>
* docs(crosswalk): update the document Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com> * fix the spell Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com> --------- Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
…usion detection and 1st/2nd attention lane (autowarefoundation#6047) Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
…utowarefoundation#5635) Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
Signed-off-by: kosuke55 <kosuke.tnp@gmail.com> remove non-support Signed-off-by: kosuke55 <kosuke.tnp@gmail.com> fix link Signed-off-by: kosuke55 <kosuke.tnp@gmail.com> add yaml Signed-off-by: kosuke55 <kosuke.tnp@gmail.com> please check readme
Signed-off-by: GitHub <noreply@github.com> Co-authored-by: github-actions <github-actions@github.com>
…on#6103) * Visualize the footprint from start_pose to end_pose along the path Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp> --------- Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>
…data structure (autowarefoundation#6101) * Add data_structs.hpp and update include paths * Refactor start planner debug data structure * Update debug_data variable name in StartPlannerModule Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp> --------- Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
…arefoundation#6055) Refactor lane departure check in ShiftPullOut::plan() Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>
…pty (autowarefoundation#6104) * check if p_safety_slow is empty Signed-off-by: beyza <bnk@leodrive.ai> * style(pre-commit): autofix --------- Signed-off-by: beyza <bnk@leodrive.ai> Co-authored-by: beyza <bnk@leodrive.ai> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
…utowarefoundation#6091) * feat!: replace use_pointcloud_container Signed-off-by: kminoda <koji.minoda@tier4.jp> * feat: remove from planning Signed-off-by: kminoda <koji.minoda@tier4.jp> * fix: fix to remove all use_pointcloud_container Signed-off-by: kminoda <koji.minoda@tier4.jp> * revert: revert change in planning.launch Signed-off-by: kminoda <koji.minoda@tier4.jp> * revert: revert rename of use_pointcloud_container Signed-off-by: kminoda <koji.minoda@tier4.jp> * fix: fix tier4_perception_launch to enable use_pointcloud_contaienr Signed-off-by: kminoda <koji.minoda@tier4.jp> * fix: fix unnecessary change Signed-off-by: kminoda <koji.minoda@tier4.jp> * fix: fix unnecessary change Signed-off-by: kminoda <koji.minoda@tier4.jp> * refactor: remove trailing whitespace Signed-off-by: kminoda <koji.minoda@tier4.jp> * revert other changes in perception Signed-off-by: kminoda <koji.minoda@tier4.jp> * revert change in readme Signed-off-by: kminoda <koji.minoda@tier4.jp> * feat: move glog to pointcloud_container.launch.py * revert: revert glog porting Signed-off-by: kminoda <koji.minoda@tier4.jp> * style(pre-commit): autofix * fix: fix pre-commit Signed-off-by: kminoda <koji.minoda@tier4.jp> --------- Signed-off-by: kminoda <koji.minoda@tier4.jp> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
…ion (autowarefoundation#6072) * add acc filtering and decaying acc to model Signed-off-by: Daniel Sanchez <daniel.sanchez@tier4.jp> * fixed compilation problem, acc is used to predict search_dist Signed-off-by: Daniel Sanchez <daniel.sanchez@tier4.jp> * Use an equivalent velocity to calculate paths Signed-off-by: Daniel Sanchez <daniel.sanchez@tier4.jp> * change decaying factor to T/4 Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com> * coment out cerr for evaluation Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com> * simplify code Signed-off-by: Daniel Sanchez <daniel.sanchez@tier4.jp> * comments Signed-off-by: Daniel Sanchez <daniel.sanchez@tier4.jp> * add missing constant to decaying acc model Signed-off-by: Daniel Sanchez <daniel.sanchez@tier4.jp> * Use an equivalent velocity to calculate paths Signed-off-by: Daniel Sanchez <daniel.sanchez@tier4.jp> * add missing constant to decaying acc model Signed-off-by: Daniel Sanchez <daniel.sanchez@tier4.jp> * Implement lanelet speed limit for acc consideration Signed-off-by: Daniel Sanchez <daniel.sanchez@tier4.jp> * add option to activate on and off acceleration feature Signed-off-by: Daniel Sanchez <daniel.sanchez@tier4.jp> * add params Signed-off-by: Daniel Sanchez <daniel.sanchez@tier4.jp> * add params Signed-off-by: Daniel Sanchez <daniel.sanchez@tier4.jp> * delete unused class Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com> * update docs Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com> * delete comments Signed-off-by: Daniel Sanchez <daniel.sanchez@tier4.jp> * fix comments Signed-off-by: Daniel Sanchez <daniel.sanchez@tier4.jp> * update comments, refactor code Signed-off-by: Daniel Sanchez <daniel.sanchez@tier4.jp> * remove unused line Signed-off-by: Daniel Sanchez <daniel.sanchez@tier4.jp> --------- Signed-off-by: Daniel Sanchez <daniel.sanchez@tier4.jp> Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com>
…om/Interplai/autoware.universe into lidar-apollo-instance-segmentation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
cc @kminoda
Thanks! |
@idorobotics |
|
@karishma1911 Hi, thank you for your contribution! Thank you for your understanding. |
…nly for `-cuda` job (autowarefoundation#5739)
Description
Implement the ROS Node configuration layout described in https://github.com/orgs/autowarefoundation/discussions/3371 for the perception_apollo_instance_segmentation
2.create schema
Tests performed
Not applicable.
Effects on system behavior
Not applicable.
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.