Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(tensorrt_common): add gtest #5174

Closed

Conversation

cyn-liu
Copy link
Contributor

@cyn-liu cyn-liu commented Sep 28, 2023

Description

add gtest to tensorrt_common

Tests performed

unit test

Effects on system behavior

There is no effect on the function.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: Cynthia Liu <cynthia.liu@autocore.ai>
@github-actions github-actions bot added the component:common Common packages from the autoware-common repository. (auto-assigned) label Sep 28, 2023
@cyn-liu cyn-liu added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Sep 28, 2023
@codecov
Copy link

codecov bot commented Sep 28, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 14.89%. Comparing base (765a596) to head (64a9b04).
Report is 3205 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5174      +/-   ##
==========================================
- Coverage   15.32%   14.89%   -0.44%     
==========================================
  Files        1721     1627      -94     
  Lines      118559   112358    -6201     
  Branches    37995    34643    -3352     
==========================================
- Hits        18169    16734    -1435     
+ Misses      79657    76868    -2789     
+ Partials    20733    18756    -1977     
Flag Coverage Δ *Carryforward flag
differential 0.00% <ø> (?)
total 14.93% <ø> (-0.40%) ⬇️ Carriedforward from fe616bd

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

stale bot commented Nov 27, 2023

This pull request has been automatically marked as stale because it has not had recent activity.

@stale stale bot added the status:stale Inactive or outdated issues. (auto-assigned) label Nov 27, 2023
@stale stale bot removed the status:stale Inactive or outdated issues. (auto-assigned) label Nov 29, 2023
@@ -16,6 +16,45 @@ if(NOT (CUDAToolkit_FOUND AND CUDNN_FOUND AND TENSORRT_FOUND))
return()
endif()

# Download onnx
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We decided not to include download scripts in CMake.
Maybe we could skip TestGetInputDims for now.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Without downloading the model this package will not be able to be tested.
so do I go ahead and write test case for this package?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To be honest, this package is not really used in autoware.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you sure about that? The header files seems to be included by the other packages. (example)

I will discuss this in the next Software WG if we could consider adding sample models in the repository or not for tests.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To be honest, this package is not really used in autoware.

@mitsudome-r
sorry, I didn't make it clear, there are 3 packages in the perception folder related to tensorrt: tensorrt_classifier , tensorrt_yolo, tensorrt_yolox, where both tensorrt_classifier and tensorrt_yolox contain the tensorrt_common, but tensorrt_yolo does not contain it. for our real car tests we only used the tensorrt_yolo.

Copy link

stale bot commented Feb 20, 2024

This pull request has been automatically marked as stale because it has not had recent activity.

@stale stale bot added the status:stale Inactive or outdated issues. (auto-assigned) label Feb 20, 2024
@xmfcx
Copy link
Contributor

xmfcx commented Dec 10, 2024

@stale stale bot removed the status:stale Inactive or outdated issues. (auto-assigned) label Dec 10, 2024
@xmfcx xmfcx closed this Dec 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:common Common packages from the autoware-common repository. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants