Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(obstacle_stop): accounting for vehicle bumper length when handling point-cloud stop points #10250

Merged

Conversation

PanConChicharron
Copy link
Contributor

@PanConChicharron PanConChicharron commented Mar 10, 2025

Description

Currently when handling point cloud points in the obstacle stop module, we do not consider the bumper length of the vehicle, causing the vehicle to brake late.

Related links

Parent Issue:

How was this PR tested?

Simulation result attached to ticket.

Notes for reviewers

None.

Interface changes

None.

Effects on system behavior

None.

@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Mar 10, 2025
Copy link

github-actions bot commented Mar 10, 2025

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

@PanConChicharron PanConChicharron added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Mar 10, 2025
@PanConChicharron PanConChicharron changed the title (fix): accounting for vehicle bumper length when handling point-cloud stop points fix(obstacle_stop): accounting for vehicle bumper length when handling point-cloud stop points Mar 10, 2025
@PanConChicharron PanConChicharron marked this pull request as ready for review March 10, 2025 07:04
@PanConChicharron PanConChicharron enabled auto-merge (squash) March 10, 2025 07:05
Copy link

codecov bot commented Mar 10, 2025

Codecov Report

Attention: Patch coverage is 0% with 6 lines in your changes missing coverage. Please review.

Project coverage is 26.23%. Comparing base (5be1ee3) to head (11467ff).
Report is 6 commits behind head on main.

Files with missing lines Patch % Lines
..._obstacle_stop_module/src/obstacle_stop_module.cpp 0.00% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #10250      +/-   ##
==========================================
- Coverage   26.24%   26.23%   -0.01%     
==========================================
  Files        1378     1378              
  Lines      107415   107444      +29     
  Branches    41411    41412       +1     
==========================================
  Hits        28189    28189              
- Misses      76412    76441      +29     
  Partials     2814     2814              
Flag Coverage Δ *Carryforward flag
differential 0.00% <0.00%> (?)
total 26.24% <ø> (+<0.01%) ⬆️ Carriedforward from e9fbf3e

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@PanConChicharron PanConChicharron merged commit e00b2af into autowarefoundation:main Mar 10, 2025
36 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants