Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(autoware_map_loader): exec name renamed in 24652f8 #10247

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
+1 −1
Open

fix(autoware_map_loader): exec name renamed in 24652f8 #10247

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion map/autoware_map_loader/launch/lanelet2_map_loader.launch.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
<param from="$(var lanelet2_map_loader_param_path)" allow_substs="true"/>
</node>

<node pkg="autoware_map_loader" exec="lanelet2_map_loader" name="lanelet2_map_loader" output="both">
<node pkg="autoware_map_loader" exec="autoware_lanelet2_map_loader" name="autoware_lanelet2_map_loader" output="both">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you keep the node name of lanelet2_map_loader?
This is because the default node name is NOT preferred to have the autoware_ prefix.
(Yes there are some other nodes that have the autoware_ prefix but we don't want autoware_ all over the place when we ros2 node list.)

Suggested change
<node pkg="autoware_map_loader" exec="autoware_lanelet2_map_loader" name="autoware_lanelet2_map_loader" output="both">
<node pkg="autoware_map_loader" exec="autoware_lanelet2_map_loader" name="lanelet2_map_loader" output="both">

<remap from="output/lanelet2_map" to="$(var lanelet2_map_topic)"/>
<param from="$(var lanelet2_map_loader_param_path)" allow_substs="true"/>
</node>
Expand Down
Loading