Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(stopline, traffic_light): fix planning factor distance value #10245

Merged
merged 1 commit into from
Mar 7, 2025

Conversation

soblin
Copy link
Contributor

@soblin soblin commented Mar 7, 2025

Description

Fixed the issue that

  • PlanningFactor distance value of stopline is negative
  • PlanningFactor distance value of traffic_light does not appear

Related links

How was this PR tested?

See the attached video in the ticket

https://evaluation.tier4.jp/evaluation/reports/b7b812c4-d000-5be2-9f9a-b2c6a8f349be?project_id=prd_jt

Notes for reviewers

None.

Interface changes

None.

Effects on system behavior

None.

@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Mar 7, 2025
Copy link

github-actions bot commented Mar 7, 2025

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
@soblin soblin force-pushed the fix/bvp-planner/stop-factor branch from 676bdf4 to deebc71 Compare March 7, 2025 06:18
Copy link
Contributor

@shmpwk shmpwk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@soblin soblin added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Mar 7, 2025
Copy link

codecov bot commented Mar 7, 2025

Codecov Report

Attention: Patch coverage is 33.33333% with 2 lines in your changes missing coverage. Please review.

Project coverage is 26.20%. Comparing base (160cf54) to head (deebc71).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
...e_behavior_velocity_stop_line_module/src/scene.cpp 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #10245      +/-   ##
==========================================
- Coverage   26.21%   26.20%   -0.01%     
==========================================
  Files        1379     1379              
  Lines      107437   107459      +22     
  Branches    41397    41399       +2     
==========================================
+ Hits        28160    28164       +4     
- Misses      76466    76483      +17     
- Partials     2811     2812       +1     
Flag Coverage Δ *Carryforward flag
differential 10.27% <33.33%> (?)
total 26.21% <ø> (+<0.01%) ⬆️ Carriedforward from 160cf54

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@soblin soblin merged commit 658c112 into autowarefoundation:main Mar 7, 2025
46 of 48 checks passed
@soblin soblin deleted the fix/bvp-planner/stop-factor branch March 7, 2025 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants