Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(planning_validator): add diag to check planning component latency #10241

Merged

Conversation

satoshi-ota
Copy link
Contributor

@satoshi-ota satoshi-ota commented Mar 6, 2025

Description

⚠️ Please review and approve autowarefoundation/autoware_launch#1347 first.

I added a feature to calculate control component latency and to publish error diagnostic if it is larger than threshold.

Related links

Parent Issue:

  • Link

How was this PR tested?

Notes for reviewers

None.

Interface changes

Add new field to publish current latency.

diff --git a/planning/autoware_planning_validator/msg/PlanningValidatorStatus.msg b/planning/autoware_planning_validator/msg/PlanningValidatorStatus.msg
index cf127347a6..d1d493761d 100644
--- a/planning/autoware_planning_validator/msg/PlanningValidatorStatus.msg
+++ b/planning/autoware_planning_validator/msg/PlanningValidatorStatus.msg
@@ -15,6 +15,7 @@ bool is_valid_velocity_deviation
 bool is_valid_distance_deviation
 bool is_valid_longitudinal_distance_deviation
 bool is_valid_forward_trajectory_length
+bool is_valid_latency
 
 # values
 int64 trajectory_size
@@ -31,5 +32,6 @@ float64 distance_deviation
 float64 longitudinal_distance_deviation
 float64 forward_trajectory_length_required
 float64 forward_trajectory_length_measured
+float64 latency
 
 int64 invalid_count

Effects on system behavior

None.

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Mar 6, 2025
Copy link

github-actions bot commented Mar 6, 2025

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

Copy link
Contributor

@kosuke55 kosuke55 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@satoshi-ota satoshi-ota added run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) run:clang-tidy-pr-review labels Mar 7, 2025
Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
Copy link

codecov bot commented Mar 7, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 26.26%. Comparing base (92da629) to head (e5846f0).
Report is 9 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #10241   +/-   ##
=======================================
  Coverage   26.25%   26.26%           
=======================================
  Files        1381     1381           
  Lines      107503   107531   +28     
  Branches    41411    41416    +5     
=======================================
+ Hits        28229    28238    +9     
- Misses      76459    76478   +19     
  Partials     2815     2815           
Flag Coverage Δ *Carryforward flag
differential 29.20% <100.00%> (?)
total 26.25% <ø> (-0.01%) ⬇️ Carriedforward from 92da629

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@satoshi-ota satoshi-ota merged commit 15fdd87 into autowarefoundation:main Mar 7, 2025
32 of 34 checks passed
@satoshi-ota satoshi-ota deleted the feat/measure-planning-latency branch March 7, 2025 10:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) run:clang-tidy-pr-review
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants