Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

obstacle pointcloud based validator node Incorrectly removes the small DetectedObjects (traffic cone) from centerpoint. #6938

Closed
3 tasks done
sgNicola opened this issue May 8, 2024 · 9 comments
Labels
component:perception Advanced sensor data processing and environment understanding. (auto-assigned)

Comments

@sgNicola
Copy link

sgNicola commented May 8, 2024

Checklist

  • I've read the contribution guidelines.
  • I've searched other issues and no duplicate issues were found.
  • I'm convinced that this is not my fault but a bug.

Description

The obstacle pointcloud-based validator node is incorrectly removing small DetectedObjects, such as traffic cones, identified by the centerpoint node. This leads to a misdetection.
traffic_cone_centerpointtopic
validator_topic

Expected behavior

The obstacle pointcloud-based validator node should accurately validate and retain all DetectedObjects recognized by the centerpoint node, including small objects like traffic cones.

Actual behavior

The CenterPoint node detects small objects (e.g., traffic cones) with low frequency, but the obstacle point cloud-based validator node subsequently removes these detections.

Steps to reproduce

  1. Launch Autoware.Universe in an environment with traffic cones as potential obstacles.
  2. Monitor the detection outputs from the centerpoint node and the subsequent validation by the obstacle pointcloud-based validator node.
  3. Observe the failure of the validator node to retain valid DetectedObjects (traffic cones) identified initially by the centerpoint node.

Versions

-OS: Ubuntu20.04
-ROS2: ROS2 galactic
-Autoware: Autoware.universe galactic

Possible causes

  1. Low Detection Frequency: The CenterPoint node may not be optimally configured or may lack the sensitivity needed to consistently detect small objects.
  2. Validation Thresholds: The obstacle point cloud-based validator node may have stringent thresholds or criteria that do not favor the retention of small, infrequently detected objects.

Additional context

No response

@meliketanrikulu meliketanrikulu added the component:perception Advanced sensor data processing and environment understanding. (auto-assigned) label May 9, 2024
@meliketanrikulu
Copy link
Contributor

@sgNicola Thanks for your contribution. Could you share example data to reproduce this problem.

@sgNicola
Copy link
Author

sgNicola commented May 9, 2024

Hi, I have shared the ros2bag in this Google Drive link [provided.]
https://drive.google.com/drive/folders/1CtjPF1jNsm2bRsyisEOX7EJDEtoroJnX?usp=drive_link

@meliketanrikulu
Copy link
Contributor

provided
@sgNicola I can not open data link . Could you check the link . Thank you

@sgNicola
Copy link
Author

Hi, @meliketanrikulu , I have checked the visiting property, could you please try again? Thank you.

@amadeuszsz
Copy link
Contributor

Hi @sgNicola
Did you fix the issue already? If not, I would like to reproduce it but your link does not have rosbag file, I see only the meta file.

@sgNicola
Copy link
Author

sgNicola commented Jul 8, 2024 via email

@amadeuszsz
Copy link
Contributor

@sgNicola
I reproduced your issue and here is brief summary:

  1. Apart of fact the cone was detected as pedestrian, indeed obstacle_pointcloud_based_validator removes tiny objects.
  2. This issue was addressed in past PR feat(detected_object_validation): add dynamic min pointcloud num #2894. Unfortunately for galactic branch users, this feature is not included.
  3. Beside this dynamic number of points calculation, this detection is still being removed. I believe our default config gives us trade off between maximizing false positives / minimizing true positives removal. Users may play with settings to fit their scenarios. Based on distance and number of points (5~ in your example) I quickly calculated desired values - for your case you would need to change desired class min_points_num to 5 and min_points_and_distance_ratio to 100 here.

obstacle_pointcloud_based_validator

I suggest to move on ROS 2 humble if it's possible and tune the config file, but keep that in mind you will end up with more false positives. I hope it will help you a lot!

@sgNicola
Copy link
Author

sgNicola commented Jul 12, 2024 via email

@amadeuszsz
Copy link
Contributor

Thank you for your help!

Closing as resolved 👍🏻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:perception Advanced sensor data processing and environment understanding. (auto-assigned)
Projects
None yet
Development

No branches or pull requests

3 participants