Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consolidate MRM related nodes into a single node #6539

Closed
3 of 4 tasks
veqcc opened this issue Mar 4, 2024 · 4 comments
Closed
3 of 4 tasks

Consolidate MRM related nodes into a single node #6539

veqcc opened this issue Mar 4, 2024 · 4 comments
Assignees
Labels
component:system System design and integration. (auto-assigned) type:improvement Proposed enhancement

Comments

@veqcc
Copy link
Contributor

veqcc commented Mar 4, 2024

Checklist

  • I've read the contribution guidelines.
  • I've searched other issues and no duplicate issues were found.
  • I've agreed with the maintainers that I can plan this task.

Description

Currently, Minimum Risk Maneuver (MRM) is implemented across multiple nodes like the following:
(Pullover is a new feature still in Pull Request: #5634)
Screenshot from 2024-03-04 14-51-23

You can refer to #1856 to see when these MRM functions are introduced in autoware.universe.

From a point of safety and performance, I suggest consolidating these five nodes into a single node.

Purpose

By consolidating these nodes, we aim to achive:

  • improving reliability: a low probability of MRM failures since redundant ROS 2 node/topic/service will be removed.
  • improving latency: a high performance of MRM behaviors on some emergency since:
    • we do not have to wait the MRM operation response from each node, or wait a timeout of some behaviors
    • we do not have to wait the topic/service to be scheduled by the ROS 2 executor

Possible approaches

Implement each operators (including pull_over_manager) as a class in MRM Handler nodes:
Screenshot from 2024-03-04 15-13-12

If you want to add a new operator to MRM, just implementing a new class in MRM Handler is fine.

Definition of done

  • consolidate these nodes into a single node
@veqcc veqcc added type:improvement Proposed enhancement component:system System design and integration. (auto-assigned) labels Mar 4, 2024
@veqcc veqcc self-assigned this Mar 4, 2024
Copy link

stale bot commented May 3, 2024

This pull request has been automatically marked as stale because it has not had recent activity.

@stale stale bot added the status:stale Inactive or outdated issues. (auto-assigned) label May 3, 2024
@meliketanrikulu
Copy link
Contributor

Hello @veqcc . Thanks for your effort. Is there any update related this issue.

@stale stale bot removed the status:stale Inactive or outdated issues. (auto-assigned) label May 9, 2024
@veqcc
Copy link
Contributor Author

veqcc commented May 10, 2024

Hi, @meliketanrikulu, thank you for your reminder.

Actualy, there will be a interface change in vehicle_cmd_gate from @isamu-takagi in the near future.
I will make some actions after that

@veqcc
Copy link
Contributor Author

veqcc commented May 28, 2024

I will close it.

@veqcc veqcc closed this as completed May 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:system System design and integration. (auto-assigned) type:improvement Proposed enhancement
Projects
None yet
Development

No branches or pull requests

2 participants