Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(traffic_light_visualization): tier4_perception_msgs should be autoware_perception_msgs in README.md #6459

Closed
3 tasks done
felixf4xu opened this issue Feb 20, 2024 · 3 comments
Labels
type:documentation Creating or refining documentation. (auto-assigned)

Comments

@felixf4xu
Copy link
Contributor

Checklist

  • I've read the contribution guidelines.
  • I've searched other issues and no duplicate issues were found.
  • I'm convinced that this is not my fault but a bug.

Description

in autoware.universe/perception/traffic_light_visualization/README.md,

| `~/input/tl_state`   | `tier4_perception_msgs::msg::TrafficLightArray` | status of traffic lights |

should be

| `~/input/tl_state`   | `autoware_perception_msgs::msg::TrafficLightArray` | status of traffic lights |

Expected behavior

readme document is aligned with latest code

Actual behavior

forgot to update readme doc after code change

Steps to reproduce

ros2 node info /perception/traffic_light_recognition/traffic_light_map_visualizer
/perception/traffic_light_recognition/traffic_light_map_visualizer
  Subscribers:
    /map/vector_map: autoware_auto_mapping_msgs/msg/HADMapBin
    /parameter_events: rcl_interfaces/msg/ParameterEvent
    /perception/traffic_light_recognition/traffic_signals: autoware_perception_msgs/msg/TrafficSignalArray
  Publishers:
    /parameter_events: rcl_interfaces/msg/ParameterEvent
    /perception/traffic_light_recognition/traffic_signals/markers: visualization_msgs/msg/MarkerArray
    /rosout: rcl_interfaces/msg/Log
  Service Servers:
    /perception/traffic_light_recognition/traffic_light_map_visualizer/describe_parameters: rcl_interfaces/srv/DescribeParameters
    /perception/traffic_light_recognition/traffic_light_map_visualizer/get_parameter_types: rcl_interfaces/srv/GetParameterTypes
    /perception/traffic_light_recognition/traffic_light_map_visualizer/get_parameters: rcl_interfaces/srv/GetParameters
    /perception/traffic_light_recognition/traffic_light_map_visualizer/list_parameters: rcl_interfaces/srv/ListParameters
    /perception/traffic_light_recognition/traffic_light_map_visualizer/set_parameters: rcl_interfaces/srv/SetParameters
    /perception/traffic_light_recognition/traffic_light_map_visualizer/set_parameters_atomically: rcl_interfaces/srv/SetParametersAtomically

Versions

v1.0 and the main branch

Possible causes

No response

Additional context

similar issue: #4158

@VRichardJP VRichardJP added the type:documentation Creating or refining documentation. (auto-assigned) label Feb 20, 2024
Copy link

stale bot commented Apr 20, 2024

This pull request has been automatically marked as stale because it has not had recent activity.

@stale stale bot added the status:stale Inactive or outdated issues. (auto-assigned) label Apr 20, 2024
@meliketanrikulu
Copy link
Contributor

Hello @felixf4xu . I couldn't see any incompatibility between the code and the README.md

| `~/input/tl_state`   | `tier4_perception_msgs::msg::TrafficLightArray` | status of traffic lights |

I see that the message type used in the package is also in the same type. : https://github.com/autowarefoundation/autoware.universe/tree/main/perception/traffic_light_visualization .

The topic you are looking at with node info is: autoware_perception_msgs/msg/TrafficSignalArray .

Can you check once again? If there is no confusion, we can close this issue.

@stale stale bot removed the status:stale Inactive or outdated issues. (auto-assigned) label May 9, 2024
@meliketanrikulu
Copy link
Contributor

I checked this @felixf4xu . The issue may have been resolved with another change after it was created but there is no difference so we can close this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:documentation Creating or refining documentation. (auto-assigned)
Projects
None yet
Development

No branches or pull requests

3 participants