Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Some improvements and bug fixes on pid_longitudinal_controller after hilly road tests #5121

Open
3 tasks done
brkay54 opened this issue Sep 25, 2023 · 5 comments
Open
3 tasks done

Some improvements and bug fixes on pid_longitudinal_controller after hilly road tests #5121

brkay54 opened this issue Sep 25, 2023 · 5 comments
Assignees
@brkay54
Labels
component:control Vehicle control algorithms and mechanisms. (auto-assigned) status:stale Inactive or outdated issues. (auto-assigned)

Comments

@brkay54
Copy link
Member

brkay54 commented Sep 25, 2023 •
edited
Loading

Checklist

  • I've read the contribution guidelines.
  • I've searched other issues and no duplicate issues were found.
  • I've agreed with the maintainers that I can plan this task.

Description

Following PRs are created to fix some unwanted behaviors we observed while testing:

These PRs should be merged in the order.
1- #4712 (merged)
2- autowarefoundation/autoware_launch#585 (merged)
3- #5077 (closed)
4- #5079
5- #5080
6- #5081

Purpose

Possible approaches

Definition of done
@brkay54 brkay54 added the component:control Vehicle control algorithms and mechanisms. (auto-assigned) label Sep 25, 2023
@brkay54 brkay54 self-assigned this Sep 25, 2023
@brkay54
Copy link
Member Author

brkay54 commented Sep 25, 2023

cc @TakaHoribe @maxime-clem @takayuki5168 I'd be happy if you could spare your time to review.

@pandyah
Copy link

pandyah commented Oct 15, 2023

It would be great if it also considers the slope Z value from the PCD file. This will be helpful for vehicles without GNSS/GPS
Thanks

@brkay54
Copy link
Member Author

brkay54 commented Oct 18, 2023 •
edited
Loading

It would be great if it also considers the slope Z value from the PCD file. This will be helpful for vehicles without GNSS/GPS Thanks

@pandyah You are right, actually, we are planning to handle it by using the ground data from perception. We are planning to improve it. Thank you for the suggestion.

@stale Stale
Copy link

stale bot commented Dec 17, 2023

This pull request has been automatically marked as stale because it has not had recent activity.

@stale stale bot added the status:stale Inactive or outdated issues. (auto-assigned) label Dec 17, 2023
@stale stale bot removed the status:stale Inactive or outdated issues. (auto-assigned) label Feb 15, 2024
@stale Stale
Copy link

stale bot commented Apr 16, 2024

This pull request has been automatically marked as stale because it has not had recent activity.

@stale stale bot added the status:stale Inactive or outdated issues. (auto-assigned) label Apr 16, 2024
@amadeuszsz amadeuszsz moved this to To Triage in Software Working Group Dec 11, 2024
@idorobotics idorobotics moved this from To Triage to In Progress in Software Working Group Feb 18, 2025
interimadd pushed a commit to interimadd/autoware.universe that referenced this issue Mar 17, 2025
@xmfcx
ci: rename self-hosted workflows to arm64 (autowarefoundation#5121)
490088f 
Signed-off-by: M. Fatih Cırıt <mfc@leodrive.ai>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@brkay54 brkay54

Labels
component:control Vehicle control algorithms and mechanisms. (auto-assigned) status:stale Inactive or outdated issues. (auto-assigned)
Projects
Software Working Group
Status: In Progress
Milestone
No milestone
Development

No branches or pull requests
2 participants
@pandyah @brkay54