fix(autoware_map_loader): exec name renamed in 24652f8 #10247
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Grzegorz Głowacki <gglowacki@autonomous-systems.pl>
ralwing
requested review from
anhnv3991,
KYabuuchi,
Motsu-san,
RyuYamamoto,
SakodaShintaro,
TaikiYamada4 and
YamatoAndo
as code owners
github-actions
bot
added
the
component:map
|
Thank you for contributing to the Autoware project! 🚧 If your pull request is in progress, switch it to draft mode. Please ensure:
|
TaikiYamada4
added
the
run:build-and-test-differential
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #10247 +/- ##
==========================================
+ Coverage 26.24% 26.25% +0.01%
==========================================
Files 1379 1381 +2
Lines 107451 107471 +20
Branches 41403 41403
==========================================
+ Hits 28204 28221 +17
- Misses 76434 76437 +3
Partials 2813 2813
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
TaikiYamada4
requested changes
Mar 10, 2025
| @@ -8,7 +8,7 @@ | |||
| <param from="$(var lanelet2_map_loader_param_path)" allow_substs="true"/> | |||
| </node> | |||
|
|
|||
| <node pkg="autoware_map_loader" exec="lanelet2_map_loader" name="lanelet2_map_loader" output="both"> | |||
| <node pkg="autoware_map_loader" exec="autoware_lanelet2_map_loader" name="autoware_lanelet2_map_loader" output="both"> | |||
There was a problem hiding this comment.
Could you keep the node name of lanelet2_map_loader?
This is because the default node name is NOT preferred to have the autoware_ prefix.
(Yes there are some other nodes that have the autoware_ prefix but we don't want autoware_ all over the place when we ros2 node list.)
Suggested change
| <node pkg="autoware_map_loader" exec="autoware_lanelet2_map_loader" name="autoware_lanelet2_map_loader" output="both"> | |
| <node pkg="autoware_map_loader" exec="autoware_lanelet2_map_loader" name="lanelet2_map_loader" output="both"> |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
exec has been renamed in 24652f834f73b13b3e4465
but wasn't renamed in default launcher.
Related links
Parent Issue:
#8927
24652f8#diff-87cd83c29c31953b416406e475004f933bad5ec63e534a5c1ca18e2747d3d534R36
Effects on system behavior
None.