build: revert clang-tidy related changes

Signed-off-by: Esteve Fernandez <esteve.fernandez@tier4.jp>

Author: esteve

planning/autoware_behavior_velocity_planner/src/node.cpp

@@ -154,7 +154,7 @@ BehaviorVelocityPlannerNode::BehaviorVelocityPlannerNode(const rclcpp::NodeOptio
   // Initialize PlannerManager
   for (const auto & name : declare_parameter<std::vector<std::string>>("launch_modules")) {
     // workaround: Since ROS 2 can't get empty list, launcher set [''] on the parameter.
-    if (name.empty()) {
+    if (name == "") {
       break;
     }
     planner_manager_.launchScenePlugin(*this, name);
@@ -182,7 +182,7 @@ void BehaviorVelocityPlannerNode::onUnloadPlugin(
 
 // NOTE: argument planner_data must not be referenced for multithreading
 bool BehaviorVelocityPlannerNode::isDataReady(
-  const PlannerData & planner_data, rclcpp::Clock clock) const
+  const PlannerData planner_data, rclcpp::Clock clock) const
 {
   const auto & d = planner_data;
 
@@ -463,7 +463,7 @@ void BehaviorVelocityPlannerNode::publishDebugMarker(
   for (size_t i = 0; i < path.points.size(); ++i) {
     visualization_msgs::msg::Marker marker;
     marker.header = path.header;
-    marker.id = static_cast<int32_t>(i);
+    marker.id = i;
     marker.type = visualization_msgs::msg::Marker::ARROW;
     marker.pose = path.points.at(i).pose;
     marker.scale.y = marker.scale.z = 0.05;

planning/autoware_behavior_velocity_planner/src/node.hpp

@@ -111,7 +111,7 @@ class BehaviorVelocityPlannerNode : public rclcpp::Node
   BehaviorVelocityPlannerManager planner_manager_;
   bool is_driving_forward_{true};
   HADMapBin::ConstSharedPtr map_ptr_{nullptr};
-  bool has_received_map_{};
+  bool has_received_map_;
 
   rclcpp::Service<LoadPlugin>::SharedPtr srv_load_plugin_;
   rclcpp::Service<UnloadPlugin>::SharedPtr srv_unload_plugin_;
@@ -125,8 +125,8 @@ class BehaviorVelocityPlannerNode : public rclcpp::Node
   std::mutex mutex_;
 
   // function
-  geometry_msgs::msg::PoseStamped get_current_pose();
-  bool isDataReady(const PlannerData & planner_data, rclcpp::Clock clock) const;
+  geometry_msgs::msg::PoseStamped getCurrentPose();
+  bool isDataReady(const PlannerData planner_data, rclcpp::Clock clock) const;
   autoware_auto_planning_msgs::msg::Path generatePath(
     const autoware_auto_planning_msgs::msg::PathWithLaneId::ConstSharedPtr input_path_msg,
     const PlannerData & planner_data);

planning/autoware_behavior_velocity_planner/src/planner_manager.cpp

@@ -35,7 +35,7 @@ std::string jsonDumpsPose(const geometry_msgs::msg::Pose & pose)
 }
 
 diagnostic_msgs::msg::DiagnosticStatus makeStopReasonDiag(
-  const std::string & stop_reason, const geometry_msgs::msg::Pose & stop_pose)
+  const std::string stop_reason, const geometry_msgs::msg::Pose & stop_pose)
 {
   diagnostic_msgs::msg::DiagnosticStatus stop_reason_diag;
   diagnostic_msgs::msg::KeyValue stop_reason_diag_kv;
@@ -83,7 +83,7 @@ void BehaviorVelocityPlannerManager::removeScenePlugin(
 {
   auto it = std::remove_if(
     scene_manager_plugins_.begin(), scene_manager_plugins_.end(),
-    [&](const std::shared_ptr<behavior_velocity_planner::PluginInterface> & plugin) {
+    [&](const std::shared_ptr<behavior_velocity_planner::PluginInterface> plugin) {
       return plugin->getModuleName() == name;
     });
 
@@ -109,11 +109,11 @@ autoware_auto_planning_msgs::msg::PathWithLaneId BehaviorVelocityPlannerManager:
   for (const auto & plugin : scene_manager_plugins_) {
     plugin->updateSceneModuleInstances(planner_data, input_path_msg);
     plugin->plan(&output_path_msg);
-    const auto first_stop_path_point_index_from_plugin = plugin->getFirstStopPathPointIndex();
+    const auto firstStopPathPointIndex = plugin->getFirstStopPathPointIndex();
 
-    if (first_stop_path_point_index_from_plugin) {
-      if (first_stop_path_point_index_from_plugin.value() < first_stop_path_point_index) {
-        first_stop_path_point_index = first_stop_path_point_index_from_plugin.value();
+    if (firstStopPathPointIndex) {
+      if (firstStopPathPointIndex.value() < first_stop_path_point_index) {
+        first_stop_path_point_index = firstStopPathPointIndex.value();
         stop_reason_msg = plugin->getModuleName();
       }
     }

planning/autoware_behavior_velocity_planner/src/planner_manager.hpp

@@ -52,7 +52,7 @@ class BehaviorVelocityPlannerManager
     const std::shared_ptr<const PlannerData> & planner_data,
     const autoware_auto_planning_msgs::msg::PathWithLaneId & input_path_msg);
 
-  [[nodiscard]] diagnostic_msgs::msg::DiagnosticStatus getStopReasonDiag() const;
+  diagnostic_msgs::msg::DiagnosticStatus getStopReasonDiag() const;
 
 private:
   diagnostic_msgs::msg::DiagnosticStatus stop_reason_diag_;

planning/autoware_behavior_velocity_planner/test/src/test_node_interface.cpp

@@ -115,8 +115,8 @@ std::shared_ptr<BehaviorVelocityPlannerNode> generateNode()
 }
 
 void publishMandatoryTopics(
-  const std::shared_ptr<PlanningInterfaceTestManager> & test_manager,
-  const std::shared_ptr<BehaviorVelocityPlannerNode> & test_target_node)
+  std::shared_ptr<PlanningInterfaceTestManager> test_manager,
+  std::shared_ptr<BehaviorVelocityPlannerNode> test_target_node)
 {
   // publish necessary topics from test_manager
   test_manager->publishTF(test_target_node, "/tf");