Skip to content

Commit

Permalink
refactor(detected_object_feature_remover)!: add package name prefix o…
Browse files Browse the repository at this point in the history
…f autoware_ (#8127)

refactor(detected_object_feature_remover): add package name prefix of autoware_

Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp>
  • Loading branch information
badai-nguyen authored Jul 22, 2024
1 parent c3bf28c commit b6a0a18
Show file tree
Hide file tree
Showing 12 changed files with 12 additions and 12 deletions.
2 changes: 1 addition & 1 deletion .github/CODEOWNERS
Original file line number Diff line number Diff line change
Expand Up @@ -119,7 +119,7 @@ perception/autoware_tracking_object_merger/** taekjin.lee@tier4.jp yoshi.ri@tier
perception/bytetrack/** manato.hirabayashi@tier4.jp yoshi.ri@tier4.jp
perception/autoware_cluster_merger/** dai.nguyen@tier4.jp shunsuke.miura@tier4.jp yukihiro.saito@tier4.jp
perception/compare_map_segmentation/** abrahammonrroy@yahoo.com dai.nguyen@tier4.jp yukihiro.saito@tier4.jp
perception/detected_object_feature_remover/** tomoya.kimura@tier4.jp
perception/autoware_detected_object_feature_remover/** tomoya.kimura@tier4.jp
perception/detected_object_validation/** dai.nguyen@tier4.jp shintaro.tomie@tier4.jp shunsuke.miura@tier4.jp yoshi.ri@tier4.jp yukihiro.saito@tier4.jp
perception/autoware_detection_by_tracker/** taekjin.lee@tier4.jp yoshi.ri@tier4.jp yukihiro.saito@tier4.jp
perception/elevation_map_loader/** kosuke.takeuchi@tier4.jp shintaro.tomie@tier4.jp taichi.higashide@tier4.jp
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -229,7 +229,7 @@
</group>
<!-- convert DynamicObjectsWithFeatureArray to DynamicObjects -->
<group>
<include file="$(find-pkg-share detected_object_feature_remover)/launch/detected_object_feature_remover.launch.xml">
<include file="$(find-pkg-share autoware_detected_object_feature_remover)/launch/detected_object_feature_remover.launch.xml">
<arg name="input" value="objects_with_feature"/>
<arg name="output" value="$(var output/rule_detector/objects)"/>
</include>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,7 @@

<!-- convert DynamicObjectsWithFeatureArray to DynamicObjects -->
<group>
<include file="$(find-pkg-share detected_object_feature_remover)/launch/detected_object_feature_remover.launch.xml">
<include file="$(find-pkg-share autoware_detected_object_feature_remover)/launch/detected_object_feature_remover.launch.xml">
<arg name="input" value="objects_with_feature"/>
<arg name="output" value="$(var output/objects)"/>
</include>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@

<!-- convert DynamicObjectsWithFeatureArray to DynamicObjects -->
<group>
<include file="$(find-pkg-share detected_object_feature_remover)/launch/detected_object_feature_remover.launch.xml">
<include file="$(find-pkg-share autoware_detected_object_feature_remover)/launch/detected_object_feature_remover.launch.xml">
<arg name="input" value="objects_with_feature"/>
<arg name="output" value="$(var output/objects)"/>
</include>
Expand Down
2 changes: 1 addition & 1 deletion launch/tier4_perception_launch/package.xml
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@

<exec_depend>autoware_cluster_merger</exec_depend>
<exec_depend>autoware_crosswalk_traffic_light_estimator</exec_depend>
<exec_depend>autoware_detected_object_feature_remover</exec_depend>
<exec_depend>autoware_detection_by_tracker</exec_depend>
<exec_depend>autoware_euclidean_cluster</exec_depend>
<exec_depend>autoware_map_based_prediction</exec_depend>
Expand All @@ -30,7 +31,6 @@
<exec_depend>autoware_raindrop_cluster_filter</exec_depend>
<exec_depend>autoware_tracking_object_merger</exec_depend>
<exec_depend>compare_map_segmentation</exec_depend>
<exec_depend>detected_object_feature_remover</exec_depend>
<exec_depend>detected_object_validation</exec_depend>
<exec_depend>elevation_map_loader</exec_depend>
<exec_depend>ground_segmentation</exec_depend>
Expand Down
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
cmake_minimum_required(VERSION 3.14)
project(detected_object_feature_remover)
project(autoware_detected_object_feature_remover)

find_package(autoware_cmake REQUIRED)
autoware_package()
Expand Down
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
# detected_object_feature_remover
# autoware_detected_object_feature_remover

## Purpose

The `detected_object_feature_remover` is a package to convert topic-type from `DetectedObjectWithFeatureArray` to `DetectedObjects`.
The `autoware_detected_object_feature_remover` is a package to convert topic-type from `DetectedObjectWithFeatureArray` to `DetectedObjects`.

## Inner-workings / Algorithms

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
<arg name="output"/>
<arg name="node_name" default="detected_object_feature_remover"/>

<node pkg="detected_object_feature_remover" exec="detected_object_feature_remover_node" name="$(var node_name)" output="screen">
<node pkg="autoware_detected_object_feature_remover" exec="detected_object_feature_remover_node" name="$(var node_name)" output="screen">
<remap from="~/input" to="$(var input)"/>
<remap from="~/output" to="$(var output)"/>
</node>
Expand Down
Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@
<?xml version="1.0"?>
<?xml-model href="http://download.ros.org/schema/package_format3.xsd" schematypens="http://www.w3.org/2001/XMLSchema"?>
<package format="3">
<name>detected_object_feature_remover</name>
<name>autoware_detected_object_feature_remover</name>
<version>0.1.0</version>
<description>The detected_object_feature_remover package</description>
<description>The autoware_detected_object_feature_remover package</description>
<maintainer email="tomoya.kimura@tier4.jp">Tomoya Kimura</maintainer>
<license>Apache License 2.0</license>

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@
</group>

<!-- convert DynamicObjectsWithFeatureArray to DynamicObjects -->
<include file="$(find-pkg-share detected_object_feature_remover)/launch/detected_object_feature_remover.launch.xml">
<include file="$(find-pkg-share autoware_detected_object_feature_remover)/launch/detected_object_feature_remover.launch.xml">
<arg name="input" value="/perception/object_recognition/detection/objects_with_feature"/>
<arg name="output" value="/perception/object_recognition/detection/objects"/>
</include>
Expand Down

0 comments on commit b6a0a18

Please sign in to comment.