fix some cppcheck error

zulfaqar-azmi-t4 · zulfaqar-azmi-t4 · commit b5e38a9dc5be · 2024-05-10T14:07:32.000+09:00
Signed-off-by: Zulfaqar Azmi &lt;zulfaqar.azmi@tier4.jp&gt;
diff --git a/planning/route_handler/test/route_parser.cpp b/planning/route_handler/test/route_parser.cpp
@@ -55,9 +55,9 @@ std::vector<LaneletPrimitive> parse_lanelet_primitives(const YAML::Node & node)
 {
   std::vector<LaneletPrimitive> primitives;
   primitives.reserve(node.size());
-  for (const auto & p : node) {
-    primitives.emplace_back(parse_lanelet_primitive(p));
-  }
+  std::transform(node.begin(), node.end(), std::back_inserter(primitives), [&](const auto & p) {
+    return parse_lanelet_primitive(p);
+  });
 
   return primitives;
 }
diff --git a/planning/route_handler/test/test_route_handler.hpp b/planning/route_handler/test/test_route_handler.hpp
@@ -40,7 +40,7 @@ using autoware_auto_mapping_msgs::msg::HADMapBin;
 class TestRouteHandler : public ::testing::Test
 {
 public:
-  TestRouteHandler() { route_handler_ = std::make_shared<RouteHandler>(makeMapBinMsg()); }
+  TestRouteHandler() : route_handler_(std::make_shared<RouteHandler>(makeMapBinMsg())) {}
   TestRouteHandler(const TestRouteHandler &) = delete;
   TestRouteHandler(TestRouteHandler &&) = delete;
   TestRouteHandler & operator=(const TestRouteHandler &) = delete;

Original file line number	Diff line number	Diff line change
`@@ -55,9 +55,9 @@ std::vector<LaneletPrimitive> parse_lanelet_primitives(const YAML::Node & node)`
`55`	`55`	`{`
`56`	`56`	`std::vector<LaneletPrimitive> primitives;`
`57`	`57`	`primitives.reserve(node.size());`
`58`		`- for (const auto & p : node) {`
`59`		`- primitives.emplace_back(parse_lanelet_primitive(p));`
`60`		`- }`
	`58`	`+ std::transform(node.begin(), node.end(), std::back_inserter(primitives), [&](const auto & p) {`
	`59`	`+ return parse_lanelet_primitive(p);`
	`60`	`+ });`
`61`	`61`
`62`	`62`	`return primitives;`
`63`	`63`	`}`
Original file line number	Diff line number	Diff line change
`@@ -40,7 +40,7 @@ using autoware_auto_mapping_msgs::msg::HADMapBin;`
`40`	`40`	`class TestRouteHandler : public ::testing::Test`
`41`	`41`	`{`
`42`	`42`	`public:`
`43`		`- TestRouteHandler() { route_handler_ = std::make_shared<RouteHandler>(makeMapBinMsg()); }`
	`43`	`+ TestRouteHandler() : route_handler_(std::make_shared<RouteHandler>(makeMapBinMsg())) {}`
`44`	`44`	`TestRouteHandler(const TestRouteHandler &) = delete;`
`45`	`45`	`TestRouteHandler(TestRouteHandler &&) = delete;`
`46`	`46`	`TestRouteHandler & operator=(const TestRouteHandler &) = delete;`