Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(autoware_ekf_localizer)!: porting from universe to core 2nd #180

Conversation

Motsu-san
Copy link
Contributor

@Motsu-san Motsu-san commented Feb 4, 2025

Description

Missing autoware_universe_utils porting autowarefoundation/autoware_utils#23, previous PRs were reverted.
We are porting autoware_ekf_localizer to autoware.core, and this PR add the package to core

Related links

Parent Issue:

How was this PR tested?

  1. Clone autoware main branch and import source files
  2. Change version on autoware.core(this PR), autoware_utils(https://github.com/autowarefoundation/autoware_utils/releases/tag/1.1.0) and autoware.universe(feat(autoware_ekf_localizer)!: porting from universe to core autoware.universe#9978) under the "src" dir
  3. Build autoware
  4. Relpay sample rosbag
  5. Confirm the behavior is alright.

Notes for reviewers

None.

Interface changes

None.

Effects on system behavior

None.

Copy link

github-actions bot commented Feb 4, 2025

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

@Motsu-san Motsu-san changed the title Feat/porting ekf localizer from universe to core feat(autoware_ekf_localizer)!: porting from universe to core Feb 4, 2025
@Motsu-san Motsu-san changed the title feat(autoware_ekf_localizer)!: porting from universe to core feat(autoware_ekf_localizer)!: porting from universe to core 2nd Feb 4, 2025
@Motsu-san Motsu-san added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Feb 4, 2025
@Motsu-san Motsu-san force-pushed the feat/porting_ekf_localizer_from_universe_to_core branch from e77c691 to 75b4201 Compare February 5, 2025 00:14
Copy link

codecov bot commented Feb 5, 2025

Codecov Report

Attention: Patch coverage is 74.01130% with 276 lines in your changes missing coverage. Please review.

Project coverage is 51.13%. Comparing base (4cb18f5) to head (5d0a137).
Report is 26 commits behind head on main.

Files with missing lines Patch % Lines
...lization/autoware_ekf_localizer/src/ekf_module.cpp 52.96% 92 Missing and 11 partials ⚠️
...ation/autoware_ekf_localizer/src/ekf_localizer.cpp 81.16% 25 Missing and 17 partials ⚠️
...n/autoware_ekf_localizer/test/test_diagnostics.cpp 74.35% 0 Missing and 30 partials ⚠️
...ware_ekf_localizer/test/test_aged_object_queue.cpp 55.76% 0 Missing and 23 partials ⚠️
...oware_ekf_localizer/test/test_state_transition.cpp 56.75% 0 Missing and 16 partials ⚠️
...on/autoware_ekf_localizer/test/test_covariance.cpp 60.52% 0 Missing and 15 partials ⚠️
...ation/autoware_ekf_localizer/test/test_numeric.cpp 37.50% 0 Missing and 10 partials ⚠️
...izer/include/autoware/ekf_localizer/ekf_module.hpp 63.15% 7 Missing ⚠️
...toware_ekf_localizer/test/test_warning_message.cpp 58.82% 0 Missing and 7 partials ⚠️
...n/autoware_ekf_localizer/test/test_measurement.cpp 75.00% 0 Missing and 6 partials ⚠️
... and 8 more
Additional details and impacted files
@@             Coverage Diff             @@
##             main     #180       +/-   ##
===========================================
- Coverage   78.75%   51.13%   -27.62%     
===========================================
  Files          11       35       +24     
  Lines         193     1627     +1434     
  Branches       73      609      +536     
===========================================
+ Hits          152      832      +680     
- Misses         11      648      +637     
- Partials       30      147      +117     
Flag Coverage Δ
differential 51.13% <74.01%> (?)
total ?

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

a-maumau and others added 18 commits February 5, 2025 09:57
…(#8888)

* import lanelet2_map_preprocessor

Signed-off-by: a-maumau <maumaumaumaumaumaumaumaumaumau@gmail.com>

* move headers to include/autoware/efk_localier

Signed-off-by: a-maumau <maumaumaumaumaumaumaumaumaumau@gmail.com>

---------

Signed-off-by: a-maumau <maumaumaumaumaumaumaumaumaumau@gmail.com>
Signed-off-by: Motsu-san <masahiro.sakamoto@tier4.jp>
…are (#8922)

add autoware prefix to localization_util

Signed-off-by: a-maumau <maumaumaumaumaumaumaumaumaumau@gmail.com>
Signed-off-by: Motsu-san <masahiro.sakamoto@tier4.jp>
Removed timer_tf_

Signed-off-by: Shintaro Sakoda <shintaro.sakoda@tier4.jp>
Signed-off-by: Motsu-san <masahiro.sakamoto@tier4.jp>
* unify package.xml version to 0.37.0

* remove system_monitor/CHANGELOG.rst

* add changelog

* 0.38.0

---------

Signed-off-by: Yutaka Kondo <yutaka.kondo@youtalk.jp>
Signed-off-by: Motsu-san <masahiro.sakamoto@tier4.jp>
…on/autoware.universe (#9304)

Signed-off-by: Esteve Fernandez <esteve.fernandez@tier4.jp>
Signed-off-by: Motsu-san <masahiro.sakamoto@tier4.jp>
Fixed to publish processing_time_ms

Signed-off-by: Shintaro Sakoda <shintaro.sakoda@tier4.jp>
Signed-off-by: Motsu-san <masahiro.sakamoto@tier4.jp>
Signed-off-by: M. Fatih Cırıt <mfc@autoware.org>
Signed-off-by: Motsu-san <masahiro.sakamoto@tier4.jp>
* chore(package.xml): bump version to 0.39.0

Signed-off-by: Yutaka Kondo <yutaka.kondo@youtalk.jp>

* fix: fix ticket links in CHANGELOG.rst

Signed-off-by: Ryohsuke Mitsudome <ryohsuke.mitsudome@tier4.jp>

* fix: remove unnecessary diff

Signed-off-by: Ryohsuke Mitsudome <ryohsuke.mitsudome@tier4.jp>

---------

Signed-off-by: Yutaka Kondo <yutaka.kondo@youtalk.jp>
Signed-off-by: Ryohsuke Mitsudome <ryohsuke.mitsudome@tier4.jp>
Co-authored-by: Yutaka Kondo <yutaka.kondo@youtalk.jp>
Signed-off-by: Motsu-san <masahiro.sakamoto@tier4.jp>
Signed-off-by: Fumiya Watanabe <rej55.g@gmail.com>
Signed-off-by: Motsu-san <masahiro.sakamoto@tier4.jp>
* check set intialpose

Signed-off-by: Yamato Ando <yamato.ando@tier4.jp>

* update png

Signed-off-by: Yamato Ando <yamato.ando@tier4.jp>

* style(pre-commit): autofix

---------

Signed-off-by: Yamato Ando <yamato.ando@tier4.jp>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Signed-off-by: Motsu-san <masahiro.sakamoto@tier4.jp>
…s localization/autoware_ekf_localizer (#9860)

Signed-off-by: vish0012 <vishalchhn42@gmail.com>
Co-authored-by: SakodaShintaro <shintaro.sakoda@tier4.jp>
Signed-off-by: Motsu-san <masahiro.sakamoto@tier4.jp>
* feat: delete ekf_localizer files

Signed-off-by: Motsu-san <masahiro.sakamoto@tier4.jp>

* doc: Modify ekf_localizer directory links

Signed-off-by: Motsu-san <masahiro.sakamoto@tier4.jp>

* ci: remove ekf_localizer from the codecov target list

Signed-off-by: Motsu-san <masahiro.sakamoto@tier4.jp>

---------

Signed-off-by: Motsu-san <masahiro.sakamoto@tier4.jp>
…to core (#9978)" (#10004)

This reverts commit 7f55945.

Signed-off-by: Ryohsuke Mitsudome <ryohsuke.mitsudome@tier4.jp>
Signed-off-by: Motsu-san <masahiro.sakamoto@tier4.jp>
Signed-off-by: Fumiya Watanabe <rej55.g@gmail.com>
Signed-off-by: Motsu-san <masahiro.sakamoto@tier4.jp>
Signed-off-by: Motsu-san <masahiro.sakamoto@tier4.jp>
Signed-off-by: Motsu-san <masahiro.sakamoto@tier4.jp>
Signed-off-by: Motsu-san <masahiro.sakamoto@tier4.jp>
…tils

Signed-off-by: Motsu-san <masahiro.sakamoto@tier4.jp>
@Motsu-san Motsu-san force-pushed the feat/porting_ekf_localizer_from_universe_to_core branch from 75b4201 to c8cfad7 Compare February 5, 2025 00:57
@Motsu-san Motsu-san marked this pull request as ready for review February 5, 2025 06:28
…lizer_from_universe_to_core

Signed-off-by: mitsudome-r <ryohsuke.mitsudome@tier4.jp>
Copy link
Contributor

@SakodaShintaro SakodaShintaro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mitsudome-r mitsudome-r merged commit 7c37655 into autowarefoundation:main Feb 13, 2025
24 of 26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants